You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/02/22 03:46:35 UTC

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8480: [Bug] [Server] delayed execution is useless

github-actions[bot] commented on issue #8480:
URL: https://github.com/apache/dolphinscheduler/issues/8480#issuecomment-1047397727


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   Set the delay execution time to 2, run the task, and the task will be executed immediately
   
   ### What you expected to happen
   
   Set the delay execution time to 2, run the task, and wait for 2 minutes to execute the task
   
   ### How to reproduce
   
   Set the delay execution time to 2 and run the task
   
   ### Anything else
   
   ````java
       public TaskInstance submitTaskInstanceToDB(TaskInstance taskInstance, ProcessInstance processInstance) {
           ExecutionStatus processInstanceState = processInstance.getState();
   
           if (taskInstance.getState().typeIsFailure()) {
               if (taskInstance.isSubProcess()) {
                   taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
               } else {
                   if (processInstanceState != ExecutionStatus.READY_STOP
                           && processInstanceState != ExecutionStatus.READY_PAUSE) {
                       // failure task set invalid
                       taskInstance.setFlag(Flag.NO);
                       updateTaskInstance(taskInstance);
                       // crate new task instance
                       if (taskInstance.getState() != ExecutionStatus.NEED_FAULT_TOLERANCE) {
                           taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
                       }
                       taskInstance.setSubmitTime(null);
                       taskInstance.setLogPath(null);
                       taskInstance.setExecutePath(null);
                       taskInstance.setStartTime(null);
                       taskInstance.setEndTime(null);
                       taskInstance.setFlag(Flag.YES);
                       taskInstance.setHost(null);
                       taskInstance.setId(0);
                   }
               }
           }
           taskInstance.setExecutorId(processInstance.getExecutorId());
           taskInstance.setProcessInstancePriority(processInstance.getProcessInstancePriority());
           taskInstance.setState(getSubmitTaskState(taskInstance, processInstanceState));
           if (taskInstance.getFirstSubmitTime() == null) {
               // The delay time is calculated according to FirstSubmitTime, SubmitTime is assigned to FirstSubmitTime, but SubmitTime is also null at this time
               taskInstance.setFirstSubmitTime(taskInstance.getSubmitTime());
           }
           boolean saveResult = saveTaskInstance(taskInstance);
           if (!saveResult) {
               return null;
           }
           return taskInstance;
       }
   ````
   
   ### Version
   
   2.0.4
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org