You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/14 17:08:22 UTC

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8113: fs: Support O_NOFOLLOW flag

xiaoxiang781216 opened a new pull request, #8113:
URL: https://github.com/apache/nuttx/pull/8113

   ## Summary
   
   https://pubs.opengroup.org/onlinepubs/9699919799.2013edition/functions/open.html: O_NOFOLLOW
   If path names a symbolic link, fail and set errno to [ELOOP].
   
   ## Impact
   
   new flag
   
   ## Testing
   
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8113: fs: Support O_NOFOLLOW flag

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8113:
URL: https://github.com/apache/nuttx/pull/8113#issuecomment-1383185513

   Yes, I think that it's better to align our macros definition to one of popular implementation(Linux and glibc is one candidate). Actually, many people include me do the unification many times before:
   https://github.com/apache/nuttx/pull/7420 https://github.com/apache/nuttx/commit/e0e18fcc74fa4286e9f2504b57fac552d54f36eb


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] acassis commented on pull request #8113: fs: Support O_NOFOLLOW flag

Posted by GitBox <gi...@apache.org>.
acassis commented on PR #8113:
URL: https://github.com/apache/nuttx/pull/8113#issuecomment-1383180629

   @xiaoxiang781216 I was trying to port 8086tiny to NuttX and noticed the author used some hardcoded valued when using open function: open(*argv, 32898)
   Do you think make sense to change our bit flags to be compatible with Linux ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] anchao merged pull request #8113: fs: Support O_NOFOLLOW flag

Posted by GitBox <gi...@apache.org>.
anchao merged PR #8113:
URL: https://github.com/apache/nuttx/pull/8113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org