You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/20 04:40:12 UTC

[GitHub] [hudi] nsivabalan commented on pull request #3824: [HUDI-1292] Millisecond granularity for instant timestamps

nsivabalan commented on pull request #3824:
URL: https://github.com/apache/hudi/pull/3824#issuecomment-947323031


   Here are the places that needs fixes
   1. compaction trigger based on [time elapsed](https://github.com/apache/hudi/blob/3686c25faee64589af6b2526e60062e7e50e51d1/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java#L143) in secs.
   
   - no changes required in metadata table. all we do is string comparison. bootstrap commit time is "0000000000000" (13 chars).
   - these are the instants used in bootstrap code. "00000000000000", "00000000000001" and "00000000000002". all of them are 14 chars. again, don't think any changes are required here. string comparison should work out even if there are strings with larger characters. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org