You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/12/26 13:43:49 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request #2967: wait a BackOff Time when rereplicate failed
StevenLuMT opened a new pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967
Descriptions of the changes in this PR:
### Motivation
the other bookie restart,rereplicate will run failed for BookieIdNotResolvedException when recover the IN_RECOVERY ledger,
then the ReplicationWorker will cost more cpu time during the other bookie is restarting.
so wait a BackOff Time when rereplicate run failed to reduce CPU Resource
### Changes
1. check rereplicate status
2. when rereplicate run fail ,call method waitBackOffTime to wait a moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh merged pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
pkumar-singh merged pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r777151669
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r779323075
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776375506
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1001841839
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776375506
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r780860462
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1001185054
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1001185054
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r775249061
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -228,8 +228,12 @@ public void run() {
while (workerRunning) {
try {
rereplicate();
+ if (!rereplicate()) {
Review comment:
Why are you calling the rereplicate method twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1011300310
@eolivelli If seems OK to you kindly approve and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r782074182
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
@eolivelli
it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1011708164
@eolivelli
if this pr has no problem , help me merge it,thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776375506
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
@eolivelli I think this log should be set to error level, it's a Interrupted Exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1001290667
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r782051633
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1010561953
> LGTM
@pkumar-singh
thanks very much,if this pr has no problem , help me merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r777151669
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1001290667
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776375506
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT edited a comment on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT edited a comment on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1002577215
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776777658
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776777658
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776777658
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1001626124
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r775307985
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -228,8 +228,12 @@ public void run() {
while (workerRunning) {
try {
rereplicate();
+ if (!rereplicate()) {
Review comment:
my mistake,I have clean it,
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776777658
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think.
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1001841839
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r777792723
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
> Why are you changing this to ERROR?
@eolivelli it may be manual or unexcept interrupted, this log's level should be warn or error, I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r775308058
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -228,8 +228,12 @@ public void run() {
while (workerRunning) {
try {
rereplicate();
+ if (!rereplicate()) {
Review comment:
> Why are you calling the rereplicate method twice?
my mistake,I have clean it,
thanks @nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r775308058
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -228,8 +228,12 @@ public void run() {
while (workerRunning) {
try {
rereplicate();
+ if (!rereplicate()) {
Review comment:
> Why are you calling the rereplicate method twice?
my mistake,I have clean it,
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1009891534
@pkumar-singh
If you have time, please help me review it, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776375506
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
@eolivelli it may be manual Interrupted,this should be warn or error,I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#issuecomment-1002577215
@nicoloboschi @dlg99 @eolivelli
If you have time, please help me review it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2967: wait a BackOff Time when rereplicate failed
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2967:
URL: https://github.com/apache/bookkeeper/pull/2967#discussion_r776329339
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java
##########
@@ -227,9 +227,12 @@ public void run() {
workerRunning = true;
while (workerRunning) {
try {
- rereplicate();
+ if (!rereplicate()) {
+ LOG.warn("failed while replicating fragments");
+ waitBackOffTime(rwRereplicateBackoffMs);
+ }
} catch (InterruptedException e) {
- LOG.info("InterruptedException "
+ LOG.error("InterruptedException "
Review comment:
Why are you changing this to ERROR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org