[jira] [Commented] (CASSANDRA-13216) testall failure in org.apache.cassandra.net.MessagingServiceTest.testDroppedMessages

["Alex Petrov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871587#comment-15871587 ] 

Alex Petrov commented on CASSANDRA-13216:
-----------------------------------------

Problem is that when the test is running subsequently or there was some test that has already modified values of dropped messages metrics, since they're stored in mbean, they'll still be retrieved. 

For example, on the subsequent run we'd get the following metrics: 
{code}
 {READ=7500, RANGE_SLICE=7500... }
{code}

Instead, we should have just gotten 0es. 

Unfortunately, dropwizard metrics does not give any simple mechanism for resetting the metrics. The path of least resistance I've currently found is just to assign a unique name to the scope while testing the metrics that have to be test-unique and resettable.

> testall failure in org.apache.cassandra.net.MessagingServiceTest.testDroppedMessages
> ------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13216
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13216
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Sean McCarthy
>              Labels: test-failure, testall
>         Attachments: TEST-org.apache.cassandra.net.MessagingServiceTest.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.11_testall/81/testReport/org.apache.cassandra.net/MessagingServiceTest/testDroppedMessages
> {code}
> Error Message
> expected:<... dropped latency: 27[30 ms and Mean cross-node dropped latency: 2731] ms> but was:<... dropped latency: 27[28 ms and Mean cross-node dropped latency: 2730] ms>
> {code}{code}
> Stacktrace
> junit.framework.AssertionFailedError: expected:<... dropped latency: 27[30 ms and Mean cross-node dropped latency: 2731] ms> but was:<... dropped latency: 27[28 ms and Mean cross-node dropped latency: 2730] ms>
> 	at org.apache.cassandra.net.MessagingServiceTest.testDroppedMessages(MessagingServiceTest.java:83)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)