You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by pr...@apache.org on 2017/02/27 07:02:15 UTC

zeppelin git commit: ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph

Repository: zeppelin
Updated Branches:
  refs/heads/master 97dfb8986 -> 47a106ab9


ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph

### What is this PR for?
On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148)

### How should this be tested?
Check screen shot.

### Screenshots (if appropriate)
Before:
![zeppelin-2148-before](https://cloud.githubusercontent.com/assets/674497/23291765/b1469780-fa80-11e6-9a13-3ecb6ca275ba.gif)

After:
![zeppelin-2148-after](https://cloud.githubusercontent.com/assets/674497/23291751/9aa39122-fa80-11e6-962e-482e12c4bca5.gif)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A

Author: Prabhjyot Singh <pr...@gmail.com>

Closes #2063 from prabhjyotsingh/ZEPPELIN-2148 and squashes the following commits:

bb66897 [Prabhjyot Singh] replace setTimeOut with $timeout
38a1198 [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/47a106ab
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/47a106ab
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/47a106ab

Branch: refs/heads/master
Commit: 47a106ab9840555f85416cc08e17ee092b5cecdf
Parents: 97dfb89
Author: Prabhjyot Singh <pr...@gmail.com>
Authored: Fri Feb 24 11:28:45 2017 +0530
Committer: Prabhjyot Singh <pr...@gmail.com>
Committed: Mon Feb 27 12:32:08 2017 +0530

----------------------------------------------------------------------
 .../src/app/notebook/paragraph/result/result.controller.js       | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/47a106ab/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
index 0430370..f308070 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
@@ -267,7 +267,9 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams, $location
 
   $scope.renderDefaultDisplay = function(targetElemId, type, data, refresh) {
     if (type === DefaultDisplayType.TABLE) {
-      $scope.renderGraph(targetElemId, $scope.graphMode, refresh);
+      $timeout(function() {
+        $scope.renderGraph(targetElemId, $scope.graphMode, refresh);
+      }, 10);
     } else if (type === DefaultDisplayType.HTML) {
       renderHtml(targetElemId, data);
     } else if (type === DefaultDisplayType.ANGULAR) {