You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bc...@apache.org on 2013/07/10 08:52:10 UTC
git commit: TS-1962 - close the connection to the server if doing a
POST/PUSH request and the POST keep-alive option is not on
Updated Branches:
refs/heads/master 492553949 -> d230caedc
TS-1962 - close the connection to the server if doing a POST/PUSH request
and the POST keep-alive option is not on
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/d230caed
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/d230caed
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/d230caed
Branch: refs/heads/master
Commit: d230caedcc0e63a9cf21bf3ffeda648a844ad562
Parents: 4925539
Author: Bryan Call <bc...@apache.org>
Authored: Tue Jul 9 23:50:47 2013 -0700
Committer: Bryan Call <bc...@apache.org>
Committed: Tue Jul 9 23:50:47 2013 -0700
----------------------------------------------------------------------
CHANGES | 3 +++
proxy/http/HttpSM.cc | 5 +++++
2 files changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d230caed/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 3ec9485..12b3133 100644
--- a/CHANGES
+++ b/CHANGES
@@ -66,6 +66,9 @@ Changes with Apache Traffic Server 3.3.5
allocation. Have seen a doubling in performance depending on the benchmark.
Details in the ticket.
+ *) [TS-1962] Don't add POST server connections to the shared pool unless POST
+ keep-alive option is on
+
Changes with Apache Traffic Server 3.3.4
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d230caed/proxy/http/HttpSM.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index 8035b38..aebdd89 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -3285,6 +3285,11 @@ HttpSM::tunnel_handler_post_ua(int event, HttpTunnelProducer * p)
case VC_EVENT_READ_COMPLETE:
case HTTP_TUNNEL_EVENT_PRECOMPLETE:
// Completed successfully
+ if (t_state.txn_conf->keep_alive_post_out == 0) {
+ // don't share the session if keep-alive for post is not on
+ set_server_session_private(true);
+ }
+
p->handler_state = HTTP_SM_POST_SUCCESS;
p->read_success = true;
ua_entry->in_tunnel = false;
Re: git commit: TS-1962 - close the connection to the server if doing a POST/PUSH request and the POST keep-alive option is not on
Posted by Bryan Call <bc...@apache.org>.
fixed
-Bryan
On Jul 10, 2013, at 2:50 AM, Igor Galić <i....@brainsware.org> wrote:
>> diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
>> index 8035b38..aebdd89 100644
>> --- a/proxy/http/HttpSM.cc
>> +++ b/proxy/http/HttpSM.cc
>> @@ -3285,6 +3285,11 @@ HttpSM::tunnel_handler_post_ua(int event,
>> HttpTunnelProducer * p)
>> case VC_EVENT_READ_COMPLETE:
>> case HTTP_TUNNEL_EVENT_PRECOMPLETE:
>> // Completed successfully
>> + if (t_state.txn_conf->keep_alive_post_out == 0) {
>> + // don't share the session if keep-alive for post is not on
>> + set_server_session_private(true);
>> + }
>> +
>
> The formatting here looks all over the place.
>
>> p->handler_state = HTTP_SM_POST_SUCCESS;
>> p->read_success = true;
>> ua_entry->in_tunnel = false;
>>
>>
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
>
Re: git commit: TS-1962 - close the connection to the server if
doing a POST/PUSH request and the POST keep-alive option is not on
Posted by Igor Galić <i....@brainsware.org>.
> diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
> index 8035b38..aebdd89 100644
> --- a/proxy/http/HttpSM.cc
> +++ b/proxy/http/HttpSM.cc
> @@ -3285,6 +3285,11 @@ HttpSM::tunnel_handler_post_ua(int event,
> HttpTunnelProducer * p)
> case VC_EVENT_READ_COMPLETE:
> case HTTP_TUNNEL_EVENT_PRECOMPLETE:
> // Completed successfully
> + if (t_state.txn_conf->keep_alive_post_out == 0) {
> + // don't share the session if keep-alive for post is not on
> + set_server_session_private(true);
> + }
> +
The formatting here looks all over the place.
> p->handler_state = HTTP_SM_POST_SUCCESS;
> p->read_success = true;
> ua_entry->in_tunnel = false;
>
>
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE