You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/25 19:55:08 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
dongjoon-hyun opened a new pull request #28929:
URL: https://github.com/apache/spark/pull/28929
### What changes were proposed in this pull request?
This PR aims to add `WorkerDecomissionExtendedSuite` for various worker decommission combinations.
### Why are the changes needed?
This will improve the test coverage.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the Jenkins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649860692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649846820
**[Test build #124518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124518/testReport)** for PR 28929 at commit [`6baeb89`](https://github.com/apache/spark/commit/6baeb890fcf9cd36567ad0d1cd5c09c9ced76aec).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class WorkerDecommissionExtendedSuite extends SparkFunSuite with LocalSparkContext `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649869826
**[Test build #124522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124522/testReport)** for PR 28929 at commit [`3da70ec`](https://github.com/apache/spark/commit/3da70eca7b64938dfdf9dc90198465b3e9103b9c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649799520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649805632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649803041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649805638
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124521/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649802448
**[Test build #124521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124521/testReport)** for PR 28929 at commit [`8ef7df8`](https://github.com/apache/spark/commit/8ef7df8672a7ae8742bbc8e4d9765e694b3033c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649805632
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649806530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk edited a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
holdenk edited a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649862971
LGTM pending jenkins, better test coverage for stuff in core is good :) Thanks @dongjoon-hyun :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk edited a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
holdenk edited a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652152637
This is not an API change just increases test coverage on already merged code. I’ll bring the SPIP to a vote this week, just been dealing with resolving some misunderstandings first.
The comment I was replying to seems to have been deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649795419
**[Test build #124519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124519/testReport)** for PR 28929 at commit [`6bc677e`](https://github.com/apache/spark/commit/6bc677e87a66f26dfebbc80a0cb1f1dfeea4d6b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649785371
cc @dbtsai and @holdenk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
holdenk removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652152637
This is not an API change just increases test coverage on already merged code. I’ll bring the SPIP to a vote this week, just been dealing with resolving some misunderstandings first.
The comment I was replying to seems to have been deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649870481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649788557
**[Test build #124518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124518/testReport)** for PR 28929 at commit [`6baeb89`](https://github.com/apache/spark/commit/6baeb890fcf9cd36567ad0d1cd5c09c9ced76aec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652144047
Wait .. the SPIP hasn't technically passed yet ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649870481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649860692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649788557
**[Test build #124518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124518/testReport)** for PR 28929 at commit [`6baeb89`](https://github.com/apache/spark/commit/6baeb890fcf9cd36567ad0d1cd5c09c9ced76aec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652162542
Yeah, I just removed as I thought it's unnecessary to raise an issue here; but if we should technically speak, SPIP wasn't passed. It's odds to merge related PRs. We should technically more think about reverting the other codes rather than merging more codes when the SPIP is in progress.
I guess it's practically fine - and that's why I just decided to remove the comments but technically I don't think this is right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649786146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649847281
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124518/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652152637
This is not an API change just increases test coverage on already merged code. I’ll bring the SPIP to a vote this week, just been dealing with resolving some misunderstandings first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649796053
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649865381
All Scala/Java/PySpark test passed, current R tests are running.
Merged to master for Apache Spark 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652162542
Yeah, I just removed as I thought it's unnecessary to raise an issue here; but if we should technically speak, SPIP wasn't passed. It's odds to merge related PRs. We should technically more think about reverting the other codes rather than merging more codes when the SPIP is in progress.
I guess it's practically fine - and that's why I just decided to remove the comments but technically I don't think this is right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649799520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649805609
**[Test build #124521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124521/testReport)** for PR 28929 at commit [`8ef7df8`](https://github.com/apache/spark/commit/8ef7df8672a7ae8742bbc8e4d9765e694b3033c2).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class WorkerDecommissionExtendedSuite extends SparkFunSuite with LocalSparkContext `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649795419
**[Test build #124519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124519/testReport)** for PR 28929 at commit [`6bc677e`](https://github.com/apache/spark/commit/6bc677e87a66f26dfebbc80a0cb1f1dfeea4d6b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649847276
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649796053
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28929:
URL: https://github.com/apache/spark/pull/28929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649803041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649862971
LGTM, better test coverage for stuff in core is good :) Thanks @dongjoon-hyun :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649847276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652144047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649806530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649809047
**[Test build #124522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124522/testReport)** for PR 28929 at commit [`3da70ec`](https://github.com/apache/spark/commit/3da70eca7b64938dfdf9dc90198465b3e9103b9c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-652144472
Let's make it pass quickly first so we don't have to block all these APIs. I am supportive of the SPIP FWIW.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649863445
Thank you, @holdenk !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649859946
**[Test build #124519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124519/testReport)** for PR 28929 at commit [`6bc677e`](https://github.com/apache/spark/commit/6bc677e87a66f26dfebbc80a0cb1f1dfeea4d6b8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649786146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28929: [SPARK-32100][CORE] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649802448
**[Test build #124521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124521/testReport)** for PR 28929 at commit [`8ef7df8`](https://github.com/apache/spark/commit/8ef7df8672a7ae8742bbc8e4d9765e694b3033c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28929: [SPARK-32100][CORE][TESTS] Add WorkerDecommissionExtendedSuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28929:
URL: https://github.com/apache/spark/pull/28929#issuecomment-649809047
**[Test build #124522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124522/testReport)** for PR 28929 at commit [`3da70ec`](https://github.com/apache/spark/commit/3da70eca7b64938dfdf9dc90198465b3e9103b9c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org