[GitHub] [doris] morrySnow commented on a diff in pull request #16125: [fix](nereids)fix bug of rule twoPhaseAggregateWithCountDistinctMulti

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #16125:
URL: https://github.com/apache/doris/pull/16125#discussion_r1089622816


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AggregateStrategies.java:
##########
@@ -416,7 +416,9 @@ private List<PhysicalHashAggregate<Plan>> twoPhaseAggregateWithCountDistinctMult
                 .build();
         PhysicalHashAggregate<Plan> gatherLocalAgg = new PhysicalHashAggregate<>(
                 localAggGroupBy, localOutput, Optional.of(partitionExpressions),
-                new AggregateParam(AggPhase.LOCAL, AggMode.INPUT_TO_BUFFER),
+                new AggregateParam(AggPhase.LOCAL,
+                        logicalAgg.getGroupByExpressions().isEmpty() ? AggMode.INPUT_TO_RESULT
+                                : AggMode.INPUT_TO_BUFFER),

Review Comment:
   core with `select count(distinct k1, NULL), avg(k2) from test;`
   maybe we set AggMode to INPUT_TO_RESULT, if and only if have no other agg function and have no group by exprs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org