You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/22 05:09:50 UTC

[GitHub] [maven-shade-plugin] kriegaex opened a new pull request #110: [MSHADE-400] Self-minimisation with custom entry points

kriegaex opened a new pull request #110:
URL: https://github.com/apache/maven-shade-plugin/pull/110


   * See https://issues.apache.org/jira/browse/MSHADE-400.
   * Solves https://issues.apache.org/jira/browse/MSHADE-366, too.
   * Contains commits from and therefore supersedes #83, #104, #108.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

Posted by GitBox <gi...@apache.org>.
kriegaex commented on pull request #110:
URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-884708342


   @JanMosigItemis, would you mind if I squashed your commits (and my early one too)? The original workaround incl. unit test is no longer necessary, nor is my refactoring of it. Only a little bit of structural test refactoring is left over.
   
   @rmannibucau, I can squash your "basic dir handling in default shader" commit too, but also try to retain it, even though Tibor is not going to like it and probably going to squash before the merge anyway. Please also be so kind as to review this PR. I think it is as far as we should go before the next major release, for which you are planning more general refactoring. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

Posted by GitBox <gi...@apache.org>.
kriegaex commented on pull request #110:
URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-884731787


   OK, I squashed into one commit, using `Co-authored-by:` to set both of you as co-authors. Looks like GitHub understands it, I did it for the first time:
   
   ![image](https://user-images.githubusercontent.com/1537384/126608271-775850be-9cb0-497e-a508-9c050a0ed78c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] kriegaex edited a comment on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

Posted by GitBox <gi...@apache.org>.
kriegaex edited a comment on pull request #110:
URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-884678704






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] JanMosigItemis commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

Posted by GitBox <gi...@apache.org>.
JanMosigItemis commented on pull request #110:
URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-884708887


   Do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #110: [MSHADE-400] Self-minimisation with custom entry points

Posted by GitBox <gi...@apache.org>.
kriegaex commented on pull request #110:
URL: https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-884678704


   The merge conflicts during the rebase were pretty ugly, because both in MSHADE-391 as well as here there was refactoring in the default shader. I hope I did not mess up anything. At least, locally the project compiles and some selected key tests for both issues are passing. Let us see what the CI builds say, before I add a specific integration test for self-minimisation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org