You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/23 10:36:09 UTC

[GitHub] [pulsar] asafm opened a new pull request, #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood

asafm opened a new pull request, #15715:
URL: https://github.com/apache/pulsar/pull/15715

   ### Modifications
   
   Add two links to Message Deduplication documentation pointing to the PIP which explains the design and how it works, and to a blog post that is also related.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `no-need-doc` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15715:
URL: https://github.com/apache/pulsar/pull/15715#issuecomment-1134521843

   @asafm:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15715:
URL: https://github.com/apache/pulsar/pull/15715


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15715:
URL: https://github.com/apache/pulsar/pull/15715#issuecomment-1134533643

   @asafm:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] asafm commented on a diff in pull request #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood

Posted by GitBox <gi...@apache.org>.
asafm commented on code in PR #15715:
URL: https://github.com/apache/pulsar/pull/15715#discussion_r881655846


##########
site2/docs/concepts-messaging.md:
##########
@@ -906,7 +906,7 @@ Message deduplication is disabled in the scenario shown at the top. Here, a prod
 In the second scenario at the bottom, the producer publishes message 1, which is received by the broker and persisted, as in the first scenario. When the producer attempts to publish the message again, however, the broker knows that it has already seen message 1 and thus does not persist the message.
 
 > Message deduplication is handled at the namespace level or the topic level. For more instructions, see the [message deduplication cookbook](cookbooks-deduplication).
-
+> You can read the design of Message Deduplication in [PIP-6](https://github.com/aahmed-se/pulsar-wiki/blob/master/PIP-6:-Guaranteed-Message-Deduplication.md), and a get an overview in this [blog post](https://www.splunk.com/en_us/blog/it/effectively-once-semantics-in-apache-pulsar.html)

Review Comment:
   @Anonymitaet I removed the blog post link for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15715:
URL: https://github.com/apache/pulsar/pull/15715#discussion_r880012715


##########
site2/docs/concepts-messaging.md:
##########
@@ -906,7 +906,7 @@ Message deduplication is disabled in the scenario shown at the top. Here, a prod
 In the second scenario at the bottom, the producer publishes message 1, which is received by the broker and persisted, as in the first scenario. When the producer attempts to publish the message again, however, the broker knows that it has already seen message 1 and thus does not persist the message.
 
 > Message deduplication is handled at the namespace level or the topic level. For more instructions, see the [message deduplication cookbook](cookbooks-deduplication).
-
+> You can read the design of Message Deduplication in [PIP-6](https://github.com/aahmed-se/pulsar-wiki/blob/master/PIP-6:-Guaranteed-Message-Deduplication.md), and a get an overview in this [blog post](https://www.splunk.com/en_us/blog/it/effectively-once-semantics-in-apache-pulsar.html)

Review Comment:
   To keep neutral and not to be challenged by ASF, we avoid adding blogs of commercial companies to the Pulsar documentation.



##########
site2/docs/concepts-messaging.md:
##########
@@ -906,7 +906,7 @@ Message deduplication is disabled in the scenario shown at the top. Here, a prod
 In the second scenario at the bottom, the producer publishes message 1, which is received by the broker and persisted, as in the first scenario. When the producer attempts to publish the message again, however, the broker knows that it has already seen message 1 and thus does not persist the message.
 
 > Message deduplication is handled at the namespace level or the topic level. For more instructions, see the [message deduplication cookbook](cookbooks-deduplication).
-
+> You can read the design of Message Deduplication in [PIP-6](https://github.com/aahmed-se/pulsar-wiki/blob/master/PIP-6:-Guaranteed-Message-Deduplication.md), and a get an overview in this [blog post](https://www.splunk.com/en_us/blog/it/effectively-once-semantics-in-apache-pulsar.html)

Review Comment:
   To keep neutral and not to be challenged by ASF, we avoid adding blogs of commercial companies to the Pulsar documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org