You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Dejan Bosanac (JIRA)" <ji...@apache.org> on 2014/03/14 14:14:45 UTC
[jira] [Commented] (AMQ-5101) MQTT SUBACK packet MUST use return
code 0x80 to report failed topic subscriptions
[ https://issues.apache.org/jira/browse/AMQ-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934975#comment-13934975 ]
Dejan Bosanac commented on AMQ-5101:
------------------------------------
I applied the patch http://git-wip-us.apache.org/repos/asf/activemq/commit/ac23b017
However, I'm seeing quite regular failings of testResendMessageId test now
{code}Tests run: 27, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 32.601 sec <<< FAILURE! - in org.apache.activemq.transport.mqtt.MQTTSSLTest
testResendMessageId(org.apache.activemq.transport.mqtt.MQTTSSLTest) Time elapsed: 1.047 sec <<< ERROR!
java.net.ProtocolException: Command from server contained an invalid message id: 4
at org.fusesource.mqtt.client.CallbackConnection.completeRequest(CallbackConnection.java:723)
at org.fusesource.mqtt.client.CallbackConnection.processFrame(CallbackConnection.java:762)
at org.fusesource.mqtt.client.CallbackConnection.access$1500(CallbackConnection.java:51)
at org.fusesource.mqtt.client.CallbackConnection$6.onTransportCommand(CallbackConnection.java:392)
at org.fusesource.hawtdispatch.transport.TcpTransport.drainInbound(TcpTransport.java:709)
at org.fusesource.hawtdispatch.transport.SslTransport.drainInbound(SslTransport.java:276)
at org.fusesource.hawtdispatch.transport.TcpTransport$6.run(TcpTransport.java:588)
at org.fusesource.hawtdispatch.internal.NioDispatchSource$3.run(NioDispatchSource.java:209)
at org.fusesource.hawtdispatch.internal.SerialDispatchQueue.run(SerialDispatchQueue.java:100)
at org.fusesource.hawtdispatch.internal.pool.SimpleThread.run(SimpleThread.java:77){code}
It's probably due the timeouts introduced in the test, but nevertheless it might be good to investigate
> MQTT SUBACK packet MUST use return code 0x80 to report failed topic subscriptions
> ---------------------------------------------------------------------------------
>
> Key: AMQ-5101
> URL: https://issues.apache.org/jira/browse/AMQ-5101
> Project: ActiveMQ
> Issue Type: Bug
> Components: MQTT
> Affects Versions: 5.9.0
> Reporter: Dhiraj Bokde
> Assignee: Dejan Bosanac
> Fix For: 5.10.0
>
> Attachments: AMQ-5101.patch
>
>
> MQTT 3.1.1 spec requires that failed topic subscriptions in a SUBACK packet MUST have a return code of 0x80 instead of the requested QoS.
> A patch is included to add this behavior.
--
This message was sent by Atlassian JIRA
(v6.2#6252)