[GitHub] [kafka] showuon commented on a diff in pull request #13239: MINOR: Various cleanups in clients javadoc

["showuon (via GitHub)" <gi...@apache.org>]

showuon commented on code in PR #13239:
URL: https://github.com/apache/kafka/pull/13239#discussion_r1105504621


##########
clients/src/main/java/org/apache/kafka/common/KafkaFuture.java:
##########
@@ -127,8 +127,6 @@ public static KafkaFuture<Void> allOf(KafkaFuture<?>... futures) {
     public abstract <R> KafkaFuture<R> thenApply(BaseFunction<T, R> function);
 
     /**
-     * @see KafkaFuture#thenApply(BaseFunction)

Review Comment:
   Why did we link to itself? Interesting



##########
clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java:
##########
@@ -44,14 +44,15 @@ public interface Partitioner extends Configurable, Closeable {
     void close();
 
     /**
-     * Note this method is only implemented in DefatultPartitioner and UniformStickyPartitioner which
-     * are now deprecated.  See KIP-794 for more info.
-     *
+     * Note this method is only implemented in DefaultPartitioner and {@link UniformStickyPartitioner} which
+     * are now deprecated. See <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-794%3A+Strictly+Uniform+Sticky+Partitioner">KIP-794</a> for more info.
+     * <p>
      * Notifies the partitioner a new batch is about to be created. When using the sticky partitioner,
      * this method can change the chosen sticky partition for the new batch.
      * @param topic The topic name
      * @param cluster The current cluster metadata
      * @param prevPartition The partition previously selected for the record that triggered a new batch
+     * @deprecated Since 3.3.0

Review Comment:
   nice catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org