You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/05/01 13:26:56 UTC

[PR] Phase 10 deferred-fix: vendor 11 remaining fixtures after upstream patches (refs #354) [grails-static-website]

jamesfredley opened a new pull request, #456:
URL: https://github.com/apache/grails-static-website/pull/456

   ## Summary
   
   Vendor the 11 guide fixtures that were deferred from PR #454 ("Phase 10 batch-3"), after patching their upstream sources in the `grails-guides` org. Brings cumulative phase-10 progress from **114/126 versions (90%)** to **125/126 versions (~99%)**.
   
   ## Upstream patches landed (6 grails-guides repos)
   
   | Upstream repo | Branch | New SHA | Fix |
   |---|---|---|---|
   | `grails-guides/discriminator-per-tenant` | master | `bca6f1a4` | Fix `tenantSelection.adoc:11` include path: `init/example` -> `services/example` (file moved during `Use GORM Data service`) |
   | `grails-guides/vaadin-grails` | grails4 | `ffe26020` | Restore `styles.scss` + `vaadin-grails-theme.scss` (deleted during `Upgrade to Grails 3.3.0`) |
   | `grails-guides/gorm-without-grails` | master | `14a7eea7` | Restore `application.properties` referenced by `creatingAppConfig.adoc` |
   | `grails-guides/grails-scheduled` | grails3 + grails4 | `a77fe4cd` / `a0eb85a8` | Restore `GenerateInvoiceJobService` + `GenerateInvoiceService` (deleted in `Delete unused files`) |
   | `grails-guides/grails-code-coverage` | grails3 + master | `b2725c0` / `35f4689` | Add `StudentController` + `StudentControllerSpec` (referenced by `unitTestIndex.adoc` but never written) |
   | `grails-guides/grails-database-migration` | grails6 | `9688dc2` | Rename `complete/grails-app/domain/grails.dbmigration/` -> `grails/dbmigration/` (literal-dot-in-dirname broke nested-package include resolver) |
   | `grails-guides/grails-google-home` | grails4 | `9de7244` | Add `AiDataController` (referenced by `data-services.adoc` but never written) |
   | `grails-guides/grails-logicaldelete` | grails3 + master | `21a3a76` / `5d61442` | Drop `buildingAnalytics` chapter (the `complete-analytics/` subapp it referenced was never written) |
   
   ## Fixtures vendored (11)
   
   * `discriminator-per-tenant` v4
   * `gorm-without-grails` v4
   * `grails-code-coverage` v3 + v4
   * `grails-database-migration` v6
   * `grails-google-home` v4
   * `grails-logicaldelete` v3 + v4
   * `grails-scheduled` v3 + v4
   * `vaadin-grails` v4
   
   All `conf/guides.yml` deferral comments removed (replaced with concrete `sampleRef` blocks). All 11 fixtures successfully ran `vendorGuide_*` and `renderGuide_*` tasks locally on Windows + JDK 21.
   
   ## Verification
   
   * `./gradlew vendorGuide_<guide>_<version>` - PASS for all 11
   * `./gradlew renderGuide_<guide>_<version>` - PASS for all 11 (each emitted `build/dist/guides/<guide>/<version>/index.html`)
   
   ## Branch convention
   
   Per the canonical-branch policy from Phase 9b standardization, each fixture pins to `grails<N>` when that branch exists, and falls back to `master` otherwise. The `vaadin-grails` fixture was originally pinned to `master` in this PR but corrected to `grails4` (which exists for that repo); see commit `85d8a0f8` for the cherry-pick + re-pin.
   
   Refs #354.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Phase 10 deferred-fix: vendor 11 remaining fixtures after upstream patches (refs #354) [grails-static-website]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #456:
URL: https://github.com/apache/grails-static-website/pull/456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org