You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Emmanuel Bourg <eb...@apache.org> on 2007/04/15 15:14:03 UTC
[configuration] Re: [nightly build] configuration failed.
I have the same version of Maven and the build works fine with the xdoc
plugin 1.8. What is wrong ?
Emmanuel Bourg
Phil Steitz a écrit :
> Failed build logs:
> http://vmbuild.apache.org/~commons/nightly/logs//20070415/configuration.log
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Emmanuel Bourg <eb...@apache.org>.
Phil Steitz a écrit :
> On 4/15/07, Emmanuel Bourg <eb...@apache.org> wrote:
>> I have the same version of Maven and the build works fine with the xdoc
>> plugin 1.8. What is wrong ?
>
> Here is what I get from maven clean xdoc on vmbuild for configuration:
>
> File...... /home/psteitz/.maven/cache/maven-xdoc-plugin-1.8/plugin.jelly
> Element... attainGoal
> Line...... 687
> Column.... 48
> No goal [xdoc:init-i18n]
>
> It is using the 1.8 version of the xdoc plugin. Are you using maven
> 1.0.2, or maven 1.1?
I have Maven 1.0.2 on Windows, with the xdoc 1.8 plugin in the Maven
plugins directory. I downgraded the version of this plugin in the
project.xml file from 1.9.2 to 1.8 to change the way the titles of the
pages are generated.
Could this be an issue with the Maven cache ?
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Phil Steitz <ph...@gmail.com>.
On 4/15/07, Emmanuel Bourg <eb...@apache.org> wrote:
> I have the same version of Maven and the build works fine with the xdoc
> plugin 1.8. What is wrong ?
Here is what I get from maven clean xdoc on vmbuild for configuration:
File...... /home/psteitz/.maven/cache/maven-xdoc-plugin-1.8/plugin.jelly
Element... attainGoal
Line...... 687
Column.... 48
No goal [xdoc:init-i18n]
It is using the 1.8 version of the xdoc plugin. Are you using maven
1.0.2, or maven 1.1?
Phil
>
> Emmanuel Bourg
>
>
> Phil Steitz a écrit :
> > Failed build logs:
> > http://vmbuild.apache.org/~commons/nightly/logs//20070415/configuration.log
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Niall Pemberton <ni...@gmail.com>.
On 4/18/07, Emmanuel Bourg <eb...@apache.org> wrote:
> I did a fresh install of Maven 1.0.2 on people.apache.org (FreeBSD 6.1,
> Java 5u7), with a fresh checkout of the code, and ran 'maven site'. The
> build failed on checkstyle with this error :
>
> Unable to create a Checker: cannot initialize module TreeWalker -
> Property 'allowMissingJavadoc' in module JavadocMethod does not exist,
> please check the documentation
>
> I had the same issue on my laptop, this property exists in the
> checkstyle documentation though. I removed the offending line and
> restarted the site generation, it completed normally.
I had the same issue when checking about RC3 - just needed to install
the latest checkstyle plugin for maven to resolve this:
http://tinyurl.com/ypcuy7
> Now I wonder why Phil's nightly builds report an xdoc error and not the
> checkstyle error. What command is used to start the nightly build ?
Maybe not related to the checkstyle issue? From memory we got the kind
of error the nightly build is seeing when the commons-build jsl script
was updated and specifying the xdoc plugin as 1.9.2 resolved it. Now
we no longer depend on commons-build - but my guess is its an isssue
with the combination of plugins /scripts installed on the nightly
build m/c. I know you revereted the plugin version from 1.9.2 back to
1.8 because of the "title style" - but since its breaking the nightly
build for configuration (and its the style most components use)
perhaps you should just switch back to the 1.9.2 version (or move to
m2)?
Niall
> Emmanuel Bourg
>
> Emmanuel Bourg a écrit :
> > I have the same version of Maven and the build works fine with the xdoc
> > plugin 1.8. What is wrong ?
> >
> > Emmanuel Bourg
> >
> >
> > Phil Steitz a écrit :
> >> Failed build logs:
> >> http://vmbuild.apache.org/~commons/nightly/logs//20070415/configuration.log
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Oliver Heger <ol...@oliver-heger.de>.
Emmanuel Bourg wrote:
> I changed TestDataConfiguration using reflection, let me know how it
> works for you. The tests with InternetAddress are skipped on Java 1.3.
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
Yes, the build works now with 1.3.
Thanks!
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Emmanuel Bourg <eb...@apache.org>.
I changed TestDataConfiguration using reflection, let me know how it
works for you. The tests with InternetAddress are skipped on Java 1.3.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Emmanuel Bourg <eb...@apache.org>.
>> Now the new dependency to javax.mail causes me trouble: Compiling with
>> JDK 1.3 fails now because the compiler reports an invalid class
>> version. The mail jar has been compiled with a JDK > 1.3. So what do
>> we do?
>
> I'll check if we can use a previous version of javamail compatible with
> Java 1.3.
I haven't found a version easily usable by Maven that is compatible with
Java 1.3. The Geronimo jars were compiled with Java 1.4.
We can either use javamail 1.3.3 from Sun (i.e more complex build
instructions) or change the test case to use reflection (it will fail,
but at least it compiles).
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Oliver Heger <ol...@oliver-heger.de>.
Emmanuel Bourg wrote:
<snip/>
>
> Actually we have the generic methods ! :) I didn't add more specialized
> get methods in DataConfiguration for the new types, instead I introduced
> generic getters :
>
> get(Class cls, String key)
>
> getArray(Class cls, String key)
>
> getList(Class cls, String key)
>
>
> The specialized getters now call the generic getters (except for Date
> and Calendar), this cuts the nloc by a half. It might be worth moving
> these methods into AbstractConfiguration now, they offer the features of
> DataConfiguration without the horde of methods. They would be a nice
> addition to the Configuration interface for the next major release too.
>
> Regarding the converters I believe we'll probably delegate this part to
> another API sooner or later (Morph, Beanutils...), but I don't want to
> add another core dependency. I was thinking about a pluggable conversion
> system, we would provide a basic implementation derived from the current
> code in PropertyConverter, and if someone wants more complex conversions
> he could plug a custom converter using another API.
>
> Emmanuel Bourg
>
Fine, then we are pretty much in line.
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Emmanuel Bourg <eb...@apache.org>.
Oliver Heger a écrit :
> I added an explicit dependency to the newest version of the checkstyle
> plugin to project.xml. This should solve the problem with checkstyle.
Thank you Oliver and Niall, it does indeed fix this issue.
> For the other problem I agree with Nial's answer: Obviously the lower
> version of the xdoc plugin causes more problems than it solves. So we
> should better go with the current version, especially if this is the
> standard for most of the commons components.
That's the easy solution I agree, I don't want to waste too much time
getting the titles right if Maven impose its own standard.
But I'm concerned about our nightly reports sending false positives
(xdoc) and missing real issues (checkstyle). Maybe it's time to
reinstall Maven for the nightly builds, or is this too much trouble ?
> Now the new dependency to javax.mail causes me trouble: Compiling with
> JDK 1.3 fails now because the compiler reports an invalid class version.
> The mail jar has been compiled with a JDK > 1.3. So what do we do?
I'll check if we can use a previous version of javamail compatible with
Java 1.3.
> In general I wonder whether all these specialized get methods make sense
> for DataConfiguration. Wouldn't it be better and more flexible to have a
> generic method
>
> Object getProperty(String key, Class targetClass)
>
> and then provide a means for registering arbitrary converters? We could
> indeed use the Beanutils converters for this purpose as was suggested by
> one jira ticket.
Actually we have the generic methods ! :) I didn't add more specialized
get methods in DataConfiguration for the new types, instead I introduced
generic getters :
get(Class cls, String key)
getArray(Class cls, String key)
getList(Class cls, String key)
The specialized getters now call the generic getters (except for Date
and Calendar), this cuts the nloc by a half. It might be worth moving
these methods into AbstractConfiguration now, they offer the features of
DataConfiguration without the horde of methods. They would be a nice
addition to the Configuration interface for the next major release too.
Regarding the converters I believe we'll probably delegate this part to
another API sooner or later (Morph, Beanutils...), but I don't want to
add another core dependency. I was thinking about a pluggable conversion
system, we would provide a basic implementation derived from the current
code in PropertyConverter, and if someone wants more complex conversions
he could plug a custom converter using another API.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Oliver Heger <ol...@oliver-heger.de>.
Emmanuel Bourg wrote:
> I did a fresh install of Maven 1.0.2 on people.apache.org (FreeBSD 6.1,
> Java 5u7), with a fresh checkout of the code, and ran 'maven site'. The
> build failed on checkstyle with this error :
>
> Unable to create a Checker: cannot initialize module TreeWalker -
> Property 'allowMissingJavadoc' in module JavadocMethod does not exist,
> please check the documentation
>
> I had the same issue on my laptop, this property exists in the
> checkstyle documentation though. I removed the offending line and
> restarted the site generation, it completed normally.
>
> Now I wonder why Phil's nightly builds report an xdoc error and not the
> checkstyle error. What command is used to start the nightly build ?
>
> Emmanuel Bourg
>
I added an explicit dependency to the newest version of the checkstyle
plugin to project.xml. This should solve the problem with checkstyle.
For the other problem I agree with Nial's answer: Obviously the lower
version of the xdoc plugin causes more problems than it solves. So we
should better go with the current version, especially if this is the
standard for most of the commons components.
Now the new dependency to javax.mail causes me trouble: Compiling with
JDK 1.3 fails now because the compiler reports an invalid class version.
The mail jar has been compiled with a JDK > 1.3. So what do we do?
In general I wonder whether all these specialized get methods make sense
for DataConfiguration. Wouldn't it be better and more flexible to have a
generic method
Object getProperty(String key, Class targetClass)
and then provide a means for registering arbitrary converters? We could
indeed use the Beanutils converters for this purpose as was suggested by
one jira ticket.
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [configuration] Re: [nightly build] configuration failed.
Posted by Emmanuel Bourg <eb...@apache.org>.
I did a fresh install of Maven 1.0.2 on people.apache.org (FreeBSD 6.1,
Java 5u7), with a fresh checkout of the code, and ran 'maven site'. The
build failed on checkstyle with this error :
Unable to create a Checker: cannot initialize module TreeWalker -
Property 'allowMissingJavadoc' in module JavadocMethod does not exist,
please check the documentation
I had the same issue on my laptop, this property exists in the
checkstyle documentation though. I removed the offending line and
restarted the site generation, it completed normally.
Now I wonder why Phil's nightly builds report an xdoc error and not the
checkstyle error. What command is used to start the nightly build ?
Emmanuel Bourg
Emmanuel Bourg a écrit :
> I have the same version of Maven and the build works fine with the xdoc
> plugin 1.8. What is wrong ?
>
> Emmanuel Bourg
>
>
> Phil Steitz a écrit :
>> Failed build logs:
>> http://vmbuild.apache.org/~commons/nightly/logs//20070415/configuration.log
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org