[jira] [Commented] (KAFKA-4722) Add application.id to StreamThread name

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850282#comment-15850282 ] 

Guozhang Wang commented on KAFKA-4722:
--------------------------------------

One side note is that we have seen some scenarios where metrics name is exceeding some framework's limit (256 bytes, e.g.) because of the long client-id, which is including the thread-id:

{code}
threadClientId = clientId + "-" + threadName;
{code}

adding application id to thread name may likely leave the threadClientId to have duplicated app.id, since clientId may contain the app.id as well, and appid itself can be long if it includes the UUID.

So I'd suggest we think through those scenarios and see if there is a better general solution to maintain uniqueness while not making the threadClientId itself to be possibly extremely long.

> Add application.id to StreamThread name
> ---------------------------------------
>
>                 Key: KAFKA-4722
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4722
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 0.10.1.1
>            Reporter: Steven Schlansker
>            Assignee: Sharad
>            Priority: Minor
>              Labels: beginner, easyfix, newbie
>
> StreamThread currently sets its name thusly:
> {code}
> super("StreamThread-" + STREAM_THREAD_ID_SEQUENCE.getAndIncrement());
> {code}
> If you have multiple {{KafkaStreams}} instance within a single application, it would help to add the application ID to {{StreamThread}} name to identify which thread belong to what {{KafkaStreams}} instance.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)