You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/04/06 10:01:30 UTC

[GitHub] flink pull request #3685: [FLINK-6079] [kafka] Provide meaningful error mess...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3685

    [FLINK-6079] [kafka] Provide meaningful error message if TopicPartitions are null

    This PR verifies that the List of topicPartitions returned by the `FlinKKafkaConsumerBase#getKafkaPartitions()` isn't null. I'm assuming this only happens when a sub-class isn't implemented correctly, as all implementations pass a non-null list. (Even the dummies pass an empty list)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6079_kafka_bull

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3685.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3685
    
----
commit 29d59776e2fdd626be0a9315aa79f5c08a25bb58
Author: zentol <ch...@apache.org>
Date:   2017-04-06T09:55:29Z

    [FLINK-6079] [kafka] Provide meaningful error message if TopicPartitions are null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3685: [FLINK-6079] [kafka] Provide meaningful error message if ...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3685
  
    Thanks for the PR! I think #3476 solves this indirectly also, but it would make sense to fix the issue with this PR first as #3476 still needs some time and massaging.
    
    LGTM, definitely an improvement to guard against subclass implementations. +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3685: [FLINK-6079] [kafka] Provide meaningful error message if ...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3685
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3685: [FLINK-6079] [kafka] Provide meaningful error mess...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3685


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---