You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/04/18 07:56:16 UTC
[PR] GH-41163: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
kou opened a new pull request, #41279:
URL: https://github.com/apache/arrow/pull/41279
### Rationale for this change
We use conda's libxml2. It didn't use `--with-tls` but 2.12.6-2 or later uses `--with-tls`. It may suppress a detected leak.
### What changes are included in this PR?
Remove `GTEST_SKIP()` for `TestGetFileInfoGenerator()`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2507279580
We can, we just have to ensure that the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2065567683
@github-actions crossbow submit test-conda-cpp-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2065394827
@github-actions crossbow submit test-conda-cpp-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2506508250
@kou What is the status on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2065569191
Revision: 5ae939b1da57d9602f852c89b28b44d6ce0c2ea5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6fb4cbfe01](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6fb4cbfe01)
|Task|Status|
|----|------|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/8746879475/job/24004466339)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41163: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2063258308
Revision: 94aa38e48d585e4b82ec71e90c39169105073fad
Submitted crossbow builds: [ursacomputing/crossbow @ actions-89dfb5be8d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-89dfb5be8d)
|Task|Status|
|----|------|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/8734372055/job/23964907642)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2506893296
Can we use Ubuntu 24.04 not 22.04 for sanitizers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41163: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2063253797
@github-actions crossbow submit test-conda-cpp-valgrind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-3706984853
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41163: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2063254201
:warning: GitHub issue #41163 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2063295353
:warning: GitHub issue #41278 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2065397334
Revision: 5e59856876f5a9c64b73cd661a8dce5b7da1eb93
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c584d2d238](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c584d2d238)
|Task|Status|
|----|------|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/8745214088/job/23999767322)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41278: [C++][FS][Azure] Run TestGetFileInfoGenerator() with Valgrind again [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41279:
URL: https://github.com/apache/arrow/pull/41279#issuecomment-2067874205
https://github.com/ursacomputing/crossbow/actions/runs/8746879475/job/24004466339#step:7:565
```text
libxml2 2.12.6 h232c23b_2 conda-forge
```
`_2` is used. So `--with-tls` version is used.
The memory leak reported by Valgrind is suppressed.
But the memory leak reported by LeakSanitizer is still reported:
https://github.com/apache/arrow/actions/runs/8746866650/job/24004437740?pr=41279#step:6:7192
```text
==13761==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 968 byte(s) in 1 object(s) allocated from:
#0 0x56514dc11538 in calloc (/build/cpp/debug/arrow-azurefs-test+0x498538) (BuildId: 2319af7306e720efeab4bdfdc43abfac31c9e76b)
#0 0x7fb2a6d5b5a4 in
```
Because it's run on Ubuntu 22.04 and it still uses libxml2 2.9.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org