You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/26 12:07:19 UTC

[GitHub] [apisix] jenskeiner commented on pull request #2859: fix: authz keycloak should run in access phase

jenskeiner commented on pull request #2859:
URL: https://github.com/apache/apisix/pull/2859#issuecomment-734261094


   > Authentication type plug-ins should run in the rewrite phase
   
   How do you suggest this get's fixed then when `openid-connect` and other authentication plugins currently run in the access phase?
   
   The plugin development guidelines are currently not in line with the actual code base.
   
   Also, what's the rationale for running authentication/authorization in the *rewrite* phase when the *access* phase is the one that specifically caters for that purpose? It's not obvious why you would run in a different phase.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org