You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/18 19:06:44 UTC
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request
#618: HDDS-2911. Fix lastUsed and stateEnterTime value in container info is
not human friendly
xiaoyuyao commented on a change in pull request #618: HDDS-2911. Fix lastUsed and stateEnterTime value in container info is not human friendly
URL: https://github.com/apache/hadoop-ozone/pull/618#discussion_r394577636
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerInfo.java
##########
@@ -98,7 +101,7 @@
this.pipelineID = pipelineID;
this.usedBytes = usedBytes;
this.numberOfKeys = numberOfKeys;
- this.lastUsed = Time.monotonicNow();
Review comment:
If you change the lastUsed and stateEnterTime to lnstant type, the code will be much simpler and clean as @elek suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org