You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "js8544 (via GitHub)" <gi...@apache.org> on 2023/02/07 10:16:09 UTC
[GitHub] [arrow] js8544 commented on a diff in pull request #34069: GH-34068: [C++ - Gandiva] Add extra functions to Gandiva
js8544 commented on code in PR #34069:
URL: https://github.com/apache/arrow/pull/34069#discussion_r1098448689
##########
cpp/src/gandiva/function_registry_math_ops.cc:
##########
@@ -62,11 +73,16 @@ namespace gandiva {
std::vector<NativeFunction> GetMathOpsFunctionRegistry() {
static std::vector<NativeFunction> math_fn_registry_ = {
MATH_UNARY_OPS(cbrt, {}), MATH_UNARY_OPS(exp, {}), MATH_UNARY_OPS(log, {}),
- MATH_UNARY_OPS(log10, {}),
+ MATH_UNARY_OPS(log10, {}), MATH_UNARY_OPS(sqrt, {}),
Review Comment:
There are existing sqrt functions in function_registry_arithmetis.cc.
##########
cpp/src/gandiva/function_registry_math_ops.cc:
##########
@@ -16,6 +16,7 @@
// under the License.
#include "gandiva/function_registry_math_ops.h"
+
Review Comment:
nit: extraneous whitespace
##########
cpp/src/gandiva/function_registry_math_ops.cc:
##########
@@ -85,9 +101,16 @@ std::vector<NativeFunction> GetMathOpsFunctionRegistry() {
MATH_UNARY_OPS(sinh, {}), MATH_UNARY_OPS(cosh, {}), MATH_UNARY_OPS(tanh, {}),
MATH_UNARY_OPS(cot, {}), MATH_UNARY_OPS(radians, {}),
MATH_UNARY_OPS(degrees, {"udfdegrees"}), MATH_BINARY_SAFE(atan2, {}),
+ MATH_UNARY_OPS_FLOAT(sinf, {}), MATH_UNARY_OPS_FLOAT(cosf, {}),
+ MATH_UNARY_OPS_FLOAT(asinf, {}), MATH_UNARY_OPS_FLOAT(acosf, {}),
+ MATH_UNARY_OPS_FLOAT(tanf, {}), MATH_UNARY_OPS_FLOAT(atanf, {}),
+ MATH_UNARY_OPS_FLOAT(sinhf, {}), MATH_UNARY_OPS_FLOAT(coshf, {}),
+ MATH_UNARY_OPS_FLOAT(tanhf, {}), MATH_UNARY_OPS_FLOAT(cotf, {}),
+ MATH_BINARY_SAFE_FLOAT(atan2f, {}),
Review Comment:
same as above.
##########
cpp/src/gandiva/function_registry_math_ops.cc:
##########
@@ -62,11 +73,16 @@ namespace gandiva {
std::vector<NativeFunction> GetMathOpsFunctionRegistry() {
static std::vector<NativeFunction> math_fn_registry_ = {
MATH_UNARY_OPS(cbrt, {}), MATH_UNARY_OPS(exp, {}), MATH_UNARY_OPS(log, {}),
- MATH_UNARY_OPS(log10, {}),
+ MATH_UNARY_OPS(log10, {}), MATH_UNARY_OPS(sqrt, {}),
+
+ MATH_UNARY_OPS_FLOAT(sqrtf, {}), MATH_UNARY_OPS_FLOAT(cbrtf, {}),
+ MATH_UNARY_OPS_FLOAT(expf, {}), MATH_UNARY_OPS_FLOAT(logf, {}),
+ MATH_UNARY_OPS_FLOAT(log10f, {}),
Review Comment:
Why not overload the existing functions?
##########
cpp/src/gandiva/function_registry_math_ops.cc:
##########
@@ -85,9 +101,16 @@ std::vector<NativeFunction> GetMathOpsFunctionRegistry() {
MATH_UNARY_OPS(sinh, {}), MATH_UNARY_OPS(cosh, {}), MATH_UNARY_OPS(tanh, {}),
MATH_UNARY_OPS(cot, {}), MATH_UNARY_OPS(radians, {}),
MATH_UNARY_OPS(degrees, {"udfdegrees"}), MATH_BINARY_SAFE(atan2, {}),
+ MATH_UNARY_OPS_FLOAT(sinf, {}), MATH_UNARY_OPS_FLOAT(cosf, {}),
+ MATH_UNARY_OPS_FLOAT(asinf, {}), MATH_UNARY_OPS_FLOAT(acosf, {}),
+ MATH_UNARY_OPS_FLOAT(tanf, {}), MATH_UNARY_OPS_FLOAT(atanf, {}),
+ MATH_UNARY_OPS_FLOAT(sinhf, {}), MATH_UNARY_OPS_FLOAT(coshf, {}),
+ MATH_UNARY_OPS_FLOAT(tanhf, {}), MATH_UNARY_OPS_FLOAT(cotf, {}),
+ MATH_BINARY_SAFE_FLOAT(atan2f, {}),
// decimal functions
UNARY_SAFE_NULL_IF_NULL(abs, {}, decimal128, decimal128),
+ UNARY_SAFE_NULL_IF_NULL(absf, {}, float32, float32),
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org