[GitHub] [skywalking] mrproliu commented on a diff in pull request #9804: Support `sumPerMinLabeled` in `MAL`

[GitBox <gi...@apache.org>]

mrproliu commented on code in PR #9804:
URL: https://github.com/apache/skywalking/pull/9804#discussion_r998160002


##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/Analyzer.java:
##########
@@ -247,8 +248,8 @@ private void init() {
     private void createMetric(final ScopeType scopeType,
                               final String dataType,
                               final DownsamplingType downsamplingType) {
-        String functionName = String.format(
-            "%s%s", downsamplingType.toString().toLowerCase(), StringUtils.capitalize(dataType));
+        String downSamplingStr = CaseUtils.toCamelCase(downsamplingType.toString().toLowerCase(), false, '_');
+        String functionName = String.format("%s%s", downSamplingStr, StringUtils.capitalize(dataType));

Review Comment:
   If we combine the downsampling(`SUM_PER_MIN`) and dataType(`labeled`), the function name would be `sum_per_minLabeled`. The format of the name is not consistent, so I change the downsampling to camel format. 
   After the change, the name is `sumPerMinLabeled`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org