You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by ma...@apache.org on 2008/04/02 14:41:11 UTC

svn commit: r643879 - /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java

Author: manugeorge
Date: Wed Apr  2 05:41:11 2008
New Revision: 643879

URL: http://svn.apache.org/viewvc?rev=643879&view=rev
Log:
OPENEJB-786: Stateless Container StrictPooling option ignored: Synchronizing on the pool object and not on the instanceManager

Modified:
    openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java

Modified: openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java?rev=643879&r1=643878&r2=643879&view=diff
==============================================================================
--- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java (original)
+++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java Wed Apr  2 05:41:11 2008
@@ -100,7 +100,7 @@
         Stack pool = data.getPool();
         Object bean = pool.pop();
         if(strictPooling){
-            synchronized(this){
+            synchronized(pool){
                 while (bean == null && pool.size() >= poolLimit) {
                     poolQueue.waitForAvailableInstance();
                     bean = pool.pop();                    
@@ -279,7 +279,7 @@
         Stack pool = data.getPool();
 
         if (strictPooling) {
-            synchronized (this) {
+            synchronized (pool) {
                 if (pool.size() < poolLimit) {
                     pool.push(bean);
                     poolQueue.notifyWaitingThreads();