You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2018/04/11 19:49:37 UTC

[GitHub] spark pull request #19627: [SPARK-21088][ML] CrossValidator, TrainValidation...

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19627#discussion_r180862523
  
    --- Diff: python/pyspark/ml/tuning.py ---
    @@ -194,7 +195,8 @@ def _to_java_impl(self):
             return java_estimator, java_epms, java_evaluator
     
     
    -class CrossValidator(Estimator, ValidatorParams, HasParallelism, MLReadable, MLWritable):
    +class CrossValidator(Estimator, ValidatorParams, HasParallelism, HasCollectSubModels,
    --- End diff --
    
    You'll need to update _from_java and _to_java as well to pass collectSubModels around.  (Same for TrainValidationSplit)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org