You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Hyunsik Choi <hy...@apache.org> on 2014/01/27 10:39:48 UTC
Review Request 17388: TAJO-372: When an exception except for network issues
occurs, the operation should not be repeated.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17388/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-372
https://issues.apache.org/jira/browse/TAJO-372
Repository: tajo
Description
-------
Currently, TajoClient retries failed operations regardless of network issues. It causes unnecessary retries as follows:
{code}
tajo> select l_shipmode, sum(case when o_orderpriority =1-URGENT or o_orderpriority =2-HIGH then 1 else 0 end) as high_line_count, sum(case when o_orderpriority <> 1-URGENT and o_orderpriority <> 2-HIGH then 1 else 0 end) as low_line_count from orders, lineitem where o_orderkey = l_orderkey and (l_shipmode = MAIL or l_shipmode = SHIP) and l_commitdate < l_receiptdate and l_shipdate < l_commitdate and l_receiptdate >= 1994-01-01 and l_receiptdate < 1995-01-01 group by l_shipmode order by l_shipmode;
Failed after attempts=3, exceptions:
org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
{code}
When the problem is caused by other problems except for network issues, the operations should be not retried.
Diffs
-----
CHANGES.txt a8676587126009fc4f1628cfa59d5ebcf9b017da
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java 9176a88262d70d08061cf1731f1bc7fc9140e68c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 4a3fc27a18611e9037360d0a32fab3f2a3e37994
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchFunctionException.java fba8d0913535b88ce73d2a18d56588edc31d7889
tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestCatalogUtil.java bda98db3387050b46453ffcb03a40a8a1adf8053
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java 5d01a1628170caa863edcb3bf20e7054d9ae6c7e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java ffa8f7a88858d53a33018bafc71847be39f1ba8a
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin6.sql 399346214436cafe1db1aefab23514d1cc3a546f
tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java 5cf830ee49f1a81f376fce117a054d5ba80574a5
tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java 143c9f7b4b25a0606efa52911ab9bd3e53832944
Diff: https://reviews.apache.org/r/17388/diff/
Testing
-------
Thanks,
Hyunsik Choi
Re: Review Request 17388: TAJO-372: When an exception except for network
issues occurs, the operation should not be repeated.
Posted by Jihoon Son <ji...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17388/#review32826
-----------------------------------------------------------
Ship it!
+1. I tested the patch on my local machine.
- Jihoon Son
On Jan. 27, 2014, 9:42 a.m., Hyunsik Choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17388/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 9:42 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-372
> https://issues.apache.org/jira/browse/TAJO-372
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Currently, TajoClient retries failed operations regardless of network issues. It causes unnecessary retries as follows:
>
> {code}
> tajo> select l_shipmode, sum(case when o_orderpriority =1-URGENT or o_orderpriority =2-HIGH then 1 else 0 end) as high_line_count, sum(case when o_orderpriority <> 1-URGENT and o_orderpriority <> 2-HIGH then 1 else 0 end) as low_line_count from orders, lineitem where o_orderkey = l_orderkey and (l_shipmode = MAIL or l_shipmode = SHIP) and l_commitdate < l_receiptdate and l_shipdate < l_commitdate and l_receiptdate >= 1994-01-01 and l_receiptdate < 1995-01-01 group by l_shipmode order by l_shipmode;
> Failed after attempts=3, exceptions:
> org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
> org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
> org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
> {code}
>
> When the problem is caused by other problems except for network issues, the operations should be not retried.
>
>
> Diffs
> -----
>
> CHANGES.txt a8676587126009fc4f1628cfa59d5ebcf9b017da
> tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java 9176a88262d70d08061cf1731f1bc7fc9140e68c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 4a3fc27a18611e9037360d0a32fab3f2a3e37994
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchFunctionException.java fba8d0913535b88ce73d2a18d56588edc31d7889
> tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestCatalogUtil.java bda98db3387050b46453ffcb03a40a8a1adf8053
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java 5d01a1628170caa863edcb3bf20e7054d9ae6c7e
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java ffa8f7a88858d53a33018bafc71847be39f1ba8a
> tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin6.sql 399346214436cafe1db1aefab23514d1cc3a546f
> tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java 5cf830ee49f1a81f376fce117a054d5ba80574a5
> tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java 143c9f7b4b25a0606efa52911ab9bd3e53832944
>
> Diff: https://reviews.apache.org/r/17388/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Hyunsik Choi
>
>
Re: Review Request 17388: TAJO-372: When an exception except for network
issues occurs, the operation should not be repeated.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17388/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 6:42 p.m.)
Review request for Tajo.
Bugs: TAJO-372
https://issues.apache.org/jira/browse/TAJO-372
Repository: tajo
Description
-------
Currently, TajoClient retries failed operations regardless of network issues. It causes unnecessary retries as follows:
{code}
tajo> select l_shipmode, sum(case when o_orderpriority =1-URGENT or o_orderpriority =2-HIGH then 1 else 0 end) as high_line_count, sum(case when o_orderpriority <> 1-URGENT and o_orderpriority <> 2-HIGH then 1 else 0 end) as low_line_count from orders, lineitem where o_orderkey = l_orderkey and (l_shipmode = MAIL or l_shipmode = SHIP) and l_commitdate < l_receiptdate and l_shipdate < l_commitdate and l_receiptdate >= 1994-01-01 and l_receiptdate < 1995-01-01 group by l_shipmode order by l_shipmode;
Failed after attempts=3, exceptions:
org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
{code}
When the problem is caused by other problems except for network issues, the operations should be not retried.
Diffs
-----
CHANGES.txt a8676587126009fc4f1628cfa59d5ebcf9b017da
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java 9176a88262d70d08061cf1731f1bc7fc9140e68c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 4a3fc27a18611e9037360d0a32fab3f2a3e37994
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchFunctionException.java fba8d0913535b88ce73d2a18d56588edc31d7889
tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestCatalogUtil.java bda98db3387050b46453ffcb03a40a8a1adf8053
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java 5d01a1628170caa863edcb3bf20e7054d9ae6c7e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java ffa8f7a88858d53a33018bafc71847be39f1ba8a
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin6.sql 399346214436cafe1db1aefab23514d1cc3a546f
tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java 5cf830ee49f1a81f376fce117a054d5ba80574a5
tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java 143c9f7b4b25a0606efa52911ab9bd3e53832944
Diff: https://reviews.apache.org/r/17388/diff/
Testing (updated)
-------
mvn clean install
Thanks,
Hyunsik Choi