You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/05/02 15:10:24 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40994: [SPARK-43319][K8S][TEST] Remove usage of deprecated DefaultKubernetesClient
dongjoon-hyun commented on code in PR #40994:
URL: https://github.com/apache/spark/pull/40994#discussion_r1182688744
##########
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala:
##########
@@ -33,7 +33,7 @@ import org.apache.spark.internal.config.JARS
import org.apache.spark.internal.config.Tests.IS_TESTING
import org.apache.spark.internal.config.UI.UI_ENABLED
-private[spark] class KubernetesTestComponents(defaultClient: DefaultKubernetesClient) {
+private[spark] class KubernetesTestComponents(val kubernetesClient: KubernetesClient) {
Review Comment:
Do we need `val` additionally, @pan3793 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org