You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/10/21 22:31:07 UTC
[kudu-CR] [clock] remove 'unsafe' tag from --use hybrid clock
Hello Yuqi Du, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19160
to look at the new patch set (#2).
Change subject: [clock] remove 'unsafe' tag from --use_hybrid_clock
......................................................................
[clock] remove 'unsafe' tag from --use_hybrid_clock
Changelist 27ac60210 added 'unsafe' tag for the --use_hybrid_clock flag.
However, that also means that setting --use_hybrid_clock=true would
require adding --unlock_unsafe_flags as well, and that's a bit strange.
To address that, this patch adds a group validator for
--use_hybrid_clock and --unlock_unsafe_flags, so now only setting
--use_hybrid_clock=false would result an error or just corresponding
warning if --unlock_unsafe_flags are added, but adding --use_hybrid_clock
--use_hybrid_clock=true wouldn't result in any error or warning.
This is a follow-up to 27ac602108ab5e6b4e2211c2bfae3b36badc3121.
Change-Id: Ie93db07f58ea3a5bac03f536852d6126e1174c3b
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/19160/2
--
To view, visit http://gerrit.cloudera.org:8080/19160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie93db07f58ea3a5bac03f536852d6126e1174c3b
Gerrit-Change-Number: 19160
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>