You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Camille Fournier (JIRA)" <ji...@apache.org> on 2011/08/12 22:28:28 UTC

[jira] [Created] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer
-------------------------------------------------------------------------------------------

                 Key: ZOOKEEPER-1152
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
             Project: ZooKeeper
          Issue Type: Bug
          Components: server
    Affects Versions: 3.3.3, 3.4.0
            Reporter: Camille Fournier
            Assignee: Camille Fournier


Exceptions thrown by an AuthenticationProvider's handleAuthentication method will not be caught, and can cause the buffers in the NIOServer to not read requests fully or properly. Any exceptions thrown here should be caught and treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-1152:
-------------------------------------

    Fix Version/s: 3.4.0

> Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1152
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method will not be caught, and can cause the buffers in the NIOServer to not read requests fully or properly. Any exceptions thrown here should be caught and treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087226#comment-13087226 ] 

Hadoop QA commented on ZOOKEEPER-1152:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12490841/ZOOKEEPER-1152.patch
  against trunk revision 1157698.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/464//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/464//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/464//console

This message is automatically generated.

> Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1152
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>         Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method will not be caught, and can cause the buffers in the NIOServer to not read requests fully or properly. Any exceptions thrown here should be caught and treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088292#comment-13088292 ] 

Benjamin Reed commented on ZOOKEEPER-1152:
------------------------------------------

+1 looks good camille. committing now.

> Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1152
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method will not be caught, and can cause the buffers in the NIOServer to not read requests fully or properly. Any exceptions thrown here should be caught and treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

Posted by "Camille Fournier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088238#comment-13088238 ] 

Camille Fournier commented on ZOOKEEPER-1152:
---------------------------------------------

Can someone please take a look at this? It would be nice to get this into 3.4 since it is a rather nasty thing to deal with.

> Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1152
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>         Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method will not be caught, and can cause the buffers in the NIOServer to not read requests fully or properly. Any exceptions thrown here should be caught and treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088605#comment-13088605 ] 

Hudson commented on ZOOKEEPER-1152:
-----------------------------------

Integrated in ZooKeeper-trunk #1272 (See [https://builds.apache.org/job/ZooKeeper-trunk/1272/])
    ZOOKEEPER-1152. Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer.

breed : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1159929
Files : 
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/AuthTest.java


> Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1152
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method will not be caught, and can cause the buffers in the NIOServer to not read requests fully or properly. Any exceptions thrown here should be caught and treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1152) Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer

Posted by "Camille Fournier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Camille Fournier updated ZOOKEEPER-1152:
----------------------------------------

    Attachment: ZOOKEEPER-1152.patch

> Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer
> -------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1152
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1152
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.3, 3.4.0
>            Reporter: Camille Fournier
>            Assignee: Camille Fournier
>         Attachments: ZOOKEEPER-1152.patch
>
>
> Exceptions thrown by an AuthenticationProvider's handleAuthentication method will not be caught, and can cause the buffers in the NIOServer to not read requests fully or properly. Any exceptions thrown here should be caught and treated as auth failure. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira