You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wayneguow (via GitHub)" <gi...@apache.org> on 2023/02/07 04:57:50 UTC

[GitHub] [spark] wayneguow commented on a diff in pull request #39906: [WIP][SPARK-41962][MINOR][SQL] Update the order of imports in class SpecificParquetRecordReaderBase

wayneguow commented on code in PR #39906:
URL: https://github.com/apache/spark/pull/39906#discussion_r1098177487


##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:
##########
@@ -28,12 +28,9 @@
 import java.util.Map;
 import java.util.Set;
 
-import com.google.common.annotations.VisibleForTesting;
-import org.apache.parquet.VersionParser;
-import org.apache.parquet.VersionParser.ParsedVersion;
-import org.apache.parquet.column.page.PageReadStore;

Review Comment:
   After pr #35945 and discussion in pr #35970, the `ImportOrder` todo has been removed, the conclusion is that it's not worth changing all unordered files.
   So shall we just make a little change for closing the related issued opened by uses?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org