[jira] [Commented] (OFBIZ-10044) Refactor and cleanup DhlServices.java

["Benjamin Jugl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054884#comment-17054884 ] 

Benjamin Jugl commented on OFBIZ-10044:
---------------------------------------

Can you please elaborate? Do you mean that we should create a plugin for any third party transportation service provider? Or just for DHL? Can we do one plugin for all, should we seperate? What led you to this demand? I see that it's nicer to run Thirdparty Services in the plugins. Are there any other reasons I don't see? This would be a much bigger project than just refactoring this one class and should probably get its own issue, don't you think?

> Refactor and cleanup DhlServices.java
> -------------------------------------
>
>                 Key: OFBIZ-10044
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10044
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> The DhlServices class contains many TODO comments and needs refactoring/cleanup.
> Hard coded defaults should be moved out to properties or database entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)