You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tyler Hobbs (JIRA)" <ji...@apache.org> on 2014/12/09 19:39:12 UTC

[jira] [Commented] (CASSANDRA-8261) Clean up schema metadata classes

    [ https://issues.apache.org/jira/browse/CASSANDRA-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239810#comment-14239810 ] 

Tyler Hobbs commented on CASSANDRA-8261:
----------------------------------------

Some of the function-related changes in the patch need to be rebased.  I'll go ahead and start reviewing it, though.

> Clean up schema metadata classes
> --------------------------------
>
>                 Key: CASSANDRA-8261
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8261
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 8261-isolate-hadcoded-system-tables.txt, 8261-isolate-serialization-code.txt, 8261-isolate-thrift-code.txt
>
>
> While working on CASSANDRA-6717, I've made some general cleanup changes to schema metadata classes - distracted from the core purpose. Also, being distracted from it by other things, every time I come back to it gives me a bit of a rebase hell.
> Thus I'm isolating those changes into a separate issue here, hoping to commit them one by one, before I go back and finalize CASSANDRA-6717.
> The changes include:
> - moving all the toThrift/fromThrift conversion code to ThriftConversion, where it belongs
> - moving the complied system CFMetaData objects away from CFMetaData (to SystemKeyspace and TracesKeyspace)
> - isolating legacy toSchema/fromSchema code into a separate class (LegacySchemaTables - former DefsTables)
> - refactoring CFMetaData/KSMetaData fields to match CQL CREATE TABLE syntax, and encapsulating more things in CompactionOptions/CompressionOptions/ReplicationOptions classes
> - moving the definition classes to the new 'schema' package



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)