You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/11 01:52:00 UTC

[jira] [Work logged] (GOBBLIN-1644) Log assigned participant when Helix participant check fails

     [ https://issues.apache.org/jira/browse/GOBBLIN-1644?focusedWorklogId=768811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768811 ]

ASF GitHub Bot logged work on GOBBLIN-1644:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/22 01:51
            Start Date: 11/May/22 01:51
    Worklog Time Spent: 10m 
      Work Description: homatthew opened a new pull request, #3506:
URL: https://github.com/apache/gobblin/pull/3506

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1644] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1644
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   Added log line for the current instance name and the assigned participant if the participant check fails
   ```
   2022-05-10 18:42:23 PDT INFO  [pool-35-thread-1] org.apache.gobblin.cluster.HelixAssignedParticipantCheck 145 - The current helix instance is not the assigned participant. helixInstanceName=WorkerInstance_0, assignedParticipant=WorkerInstance_0
   ```
   Ignore how the names are the same. I added some temp code to trigger the log line in the UT
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Doesn't need tests. its just a log line
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 768811)
    Remaining Estimate: 0h
            Time Spent: 10m

> Log assigned participant when Helix participant check fails
> -----------------------------------------------------------
>
>                 Key: GOBBLIN-1644
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1644
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-cluster
>            Reporter: Matthew Ho
>            Assignee: Hung Tran
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The logs don't explain what the actual assigned participant is when it fails. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)