You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/06/01 11:24:54 UTC
[GitHub] [activemq-artemis] gtully opened a new pull request #3601: ARTEMIS-3323 - ensure openwire message id is unique and consistent fo…
gtully opened a new pull request #3601:
URL: https://github.com/apache/activemq-artemis/pull/3601
…r the life of a broker when converted from core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on a change in pull request #3601: ARTEMIS-3323 - ensure openwire message id is unique and consistent fo…
Posted by GitBox <gi...@apache.org>.
gtully commented on a change in pull request #3601:
URL: https://github.com/apache/activemq-artemis/pull/3601#discussion_r643390928
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/interop/GeneralInteropTest.java
##########
@@ -243,17 +243,60 @@ public void testFailoverReceivingFromCore() throws Exception {
assertEquals(text + 1, ((TextMessage)message).getText());
message.acknowledge();
+ System.err.println("id: " + message.getJMSMessageID());
Review comment:
good catch. removed that. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3601: ARTEMIS-3323 - ensure openwire message id is unique and consistent fo…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3601:
URL: https://github.com/apache/activemq-artemis/pull/3601#discussion_r643368247
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/interop/GeneralInteropTest.java
##########
@@ -243,17 +243,60 @@ public void testFailoverReceivingFromCore() throws Exception {
assertEquals(text + 1, ((TextMessage)message).getText());
message.acknowledge();
+ System.err.println("id: " + message.getJMSMessageID());
Review comment:
logger.debug
is this by accident?
I had recently (an year or so ago) removed all System.outs and System.errs from the test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully merged pull request #3601: ARTEMIS-3323 - ensure openwire message id is unique and consistent fo…
Posted by GitBox <gi...@apache.org>.
gtully merged pull request #3601:
URL: https://github.com/apache/activemq-artemis/pull/3601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3601: ARTEMIS-3323 - ensure openwire message id is unique and consistent fo…
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3601:
URL: https://github.com/apache/activemq-artemis/pull/3601#issuecomment-852340060
other than the System.err that seems an accident. (If you intended for it, it's best to use logger.debug() anyways) it LGTM.
As long as the test suite is green and if you fix the System.err.println() this is good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org