You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/11 08:06:37 UTC

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9500: [fix](storage) fix core for string predicate in storage layer

yiguolei commented on code in PR #9500:
URL: https://github.com/apache/incubator-doris/pull/9500#discussion_r869996443


##########
be/src/vec/columns/predicate_column.h:
##########
@@ -410,6 +429,9 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
 
 private:
     Container data;
+    // manages the memory for slice's data(For string type)
+    std::unique_ptr<MemPool> _pool;
+    bool _is_mem_pool_inited = false;;

Review Comment:
   just check _pool == nullptr?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org