You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by zu...@apache.org on 2023/03/29 03:01:41 UTC

[incubator-uniffle] branch master updated: chore(spark): remove noisy log in client side (#776)

This is an automated email from the ASF dual-hosted git repository.

zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new be152b47 chore(spark): remove noisy log in client side (#776)
be152b47 is described below

commit be152b47a442dd65597b2363206d769585c073f3
Author: Junfan Zhang <zu...@apache.org>
AuthorDate: Wed Mar 29 11:01:35 2023 +0800

    chore(spark): remove noisy log in client side (#776)
    
    ### What changes were proposed in this pull request?
    
    1. Remove unnecessary log
    2. Make some unimportant log with debug level.
    3. Remove extra spaces
    
    ### Why are the changes needed?
    
    Avoid too much noisy log in client side when running spark jobs
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Don't need
---
 .../main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java | 4 ++--
 .../java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java   | 1 -
 .../uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java   | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java b/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java
index 580fce69..c921848f 100644
--- a/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java
+++ b/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java
@@ -297,7 +297,7 @@ public class WriteBufferManager extends MemoryConsumer {
       shuffleBlockInfosPerEvent.add(sbi);
       // split shuffle data according to the size
       if (totalSize > sendSizeLimit) {
-        LOG.info("Build event with " + shuffleBlockInfosPerEvent.size()
+        LOG.debug("Build event with " + shuffleBlockInfosPerEvent.size()
             + " blocks and " + totalSize + " bytes");
         // Use final temporary variables for closures
         final long _memoryUsed = memoryUsed;
@@ -310,7 +310,7 @@ public class WriteBufferManager extends MemoryConsumer {
       }
     }
     if (!shuffleBlockInfosPerEvent.isEmpty()) {
-      LOG.info("Build event with " + shuffleBlockInfosPerEvent.size()
+      LOG.debug("Build event with " + shuffleBlockInfosPerEvent.size()
           + " blocks and " + totalSize + " bytes");
       // Use final temporary variables for closures
       final long _memoryUsed = memoryUsed;
diff --git a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
index 54a8e8a3..1bd02ad3 100644
--- a/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
+++ b/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
@@ -415,7 +415,6 @@ public class ShuffleWriteClientImpl implements ShuffleWriteClient {
     } catch (Exception e) {
       LOG.error("Error on getting user from ugi.", e);
     }
-    LOG.info("User: {}", user);
 
     RssRegisterShuffleRequest request =
         new RssRegisterShuffleRequest(appId, shuffleId, partitionRanges, remoteStorage, user, dataDistributionType);
diff --git a/storage/src/main/java/org/apache/uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java b/storage/src/main/java/org/apache/uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java
index 915285cf..bb891a88 100644
--- a/storage/src/main/java/org/apache/uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java
+++ b/storage/src/main/java/org/apache/uniffle/storage/handler/impl/PooledHdfsShuffleWriteHandler.java
@@ -50,7 +50,7 @@ public class PooledHdfsShuffleWriteHandler implements ShuffleWriteHandler {
   @VisibleForTesting
   public PooledHdfsShuffleWriteHandler(LinkedBlockingDeque<ShuffleWriteHandler> queue) {
     this.queue = queue;
-    this.maxConcurrency =  queue.size();
+    this.maxConcurrency = queue.size();
     this.basePath = StringUtils.EMPTY;
   }