You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "gene-bordegaray (via GitHub)" <gi...@apache.org> on 2026/06/05 16:56:16 UTC
[PR] Add logical range partitioning representation [datafusion]
gene-bordegaray opened a new pull request, #22777:
URL: https://github.com/apache/datafusion/pull/22777
## Which issue does this PR close?
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "gene-bordegaray (via GitHub)" <gi...@apache.org>.
gene-bordegaray commented on PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#issuecomment-4634414741
cc: @gabotechs @stuhood
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "gene-bordegaray (via GitHub)" <gi...@apache.org>.
gene-bordegaray commented on PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#issuecomment-4668925341
Sorry for not responding when travelling but addressed comments, thanks @gabotechs 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Add logical range partitioning representation [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#issuecomment-4633843649
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion v53.1.0 (current)
Built [ 103.808s] (current)
Parsing datafusion v53.1.0 (current)
Parsed [ 0.037s] (current)
Building datafusion v53.1.0 (baseline)
Built [ 100.980s] (baseline)
Parsing datafusion v53.1.0 (baseline)
Parsed [ 0.039s] (baseline)
Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch)
Checked [ 0.962s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 207.764s] datafusion
Building datafusion-common v53.1.0 (current)
Built [ 34.680s] (current)
Parsing datafusion-common v53.1.0 (current)
Parsed [ 0.065s] (current)
Building datafusion-common v53.1.0 (baseline)
Built [ 34.111s] (baseline)
Parsing datafusion-common v53.1.0 (baseline)
Parsed [ 0.063s] (baseline)
Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch)
Checked [ 1.031s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 71.215s] datafusion-common
Building datafusion-expr v53.1.0 (current)
Built [ 26.907s] (current)
Parsing datafusion-expr v53.1.0 (current)
Parsed [ 0.078s] (current)
Building datafusion-expr v53.1.0 (baseline)
Built [ 27.096s] (baseline)
Parsing datafusion-expr v53.1.0 (baseline)
Parsed [ 0.080s] (baseline)
Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch)
Checked [ 1.774s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip
--- failure enum_variant_added: enum variant added on exhaustive enum ---
Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron
Failed in:
variant Partitioning:Range in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4450
variant Partitioning:Range in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4450
--- warning partial_ord_enum_variants_reordered: enum variants reordered in #[derive(PartialOrd)] enum ---
Description:
A public enum that derives PartialOrd had its variants reordered. #[derive(PartialOrd)] uses the enum variant order to set the enum's ordering behavior, so this change may break downstream code that relies on the previous order.
ref: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/partial_ord_enum_variants_reordered.ron
Failed in:
Partitioning::DistributeBy moved from position 3 to 4, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4452
Partitioning::DistributeBy moved from position 3 to 4, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4452
Summary semver requires new major version: 1 major and 0 minor checks failed
Warning produced 1 major and 0 minor level warnings
Finished [ 57.611s] datafusion-expr
Building datafusion-physical-expr v53.1.0 (current)
Built [ 28.895s] (current)
Parsing datafusion-physical-expr v53.1.0 (current)
Parsed [ 0.051s] (current)
Building datafusion-physical-expr v53.1.0 (baseline)
Built [ 28.985s] (baseline)
Parsing datafusion-physical-expr v53.1.0 (baseline)
Parsed [ 0.054s] (baseline)
Checking datafusion-physical-expr v53.1.0 -> v53.1.0 (no change; assume patch)
Checked [ 0.541s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip
--- failure struct_missing: pub struct removed or renamed ---
Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_missing.ron
Failed in:
struct datafusion_physical_expr::SplitPoint, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a5cdb2ad55310fc69c38f794c984085911be093f/datafusion/physical-expr/src/partitioning.rs:225
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 59.682s] datafusion-physical-expr
Building datafusion-proto v53.1.0 (current)
Built [ 59.909s] (current)
Parsing datafusion-proto v53.1.0 (current)
Parsed [ 0.019s] (current)
Building datafusion-proto v53.1.0 (baseline)
Built [ 60.061s] (baseline)
Parsing datafusion-proto v53.1.0 (baseline)
Parsed [ 0.022s] (baseline)
Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch)
Checked [ 0.375s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 122.088s] datafusion-proto
Building datafusion-substrait v53.1.0 (current)
Built [ 343.611s] (current)
Parsing datafusion-substrait v53.1.0 (current)
Parsed [ 0.018s] (current)
Building datafusion-substrait v53.1.0 (baseline)
Built [ 344.503s] (baseline)
Parsing datafusion-substrait v53.1.0 (baseline)
Parsed [ 0.021s] (baseline)
Checking datafusion-substrait v53.1.0 -> v53.1.0 (no change; assume patch)
Checked [ 0.303s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 690.609s] datafusion-substrait
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "stuhood (via GitHub)" <gi...@apache.org>.
stuhood commented on code in PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#discussion_r3365157206
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1264,6 +1264,11 @@ impl DefaultPhysicalPlanner {
.collect::<Result<Vec<_>>>()?;
Partitioning::Hash(runtime_expr, *n)
}
+ LogicalPartitioning::Range(_) => {
+ return not_impl_err!(
+ "Physical plan does not support Range repartitioning"
+ );
Review Comment:
This is a TODO, right? Should it point at a ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "gabotechs (via GitHub)" <gi...@apache.org>.
gabotechs commented on code in PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#discussion_r3372997220
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -4397,22 +4428,142 @@ impl Debug for Subquery {
}
}
-/// Logical partitioning schemes supported by [`LogicalPlan::Repartition`]
+/// Logical partitioning schemes.
///
-/// See [`Partitioning`] for more details on partitioning
+/// A scheme can describe either requested repartitioning in
+/// [`LogicalPlan::Repartition`] or a partitioning property declared by a source.
+/// Some schemes are only valid as metadata until planner support is added.
///
-/// [`Partitioning`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/enum.Partitioning.html#
+/// For physical execution partitioning, see
+/// [`datafusion_physical_expr::Partitioning`].
+///
+/// [`datafusion_physical_expr::Partitioning`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/enum.Partitioning.html#
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
pub enum Partitioning {
/// Allocate batches using a round-robin algorithm and the specified number of partitions
RoundRobinBatch(usize),
/// Allocate rows based on a hash of one of more expressions and the specified number
/// of partitions.
Hash(Vec<Expr>, usize),
+ /// Partition rows by ranges.
+ /// See [`RangePartitioning`] for the logical contract.
+ Range(RangePartitioning),
/// The DISTRIBUTE BY clause is used to repartition the data based on the input expressions
DistributeBy(Vec<Expr>),
}
+impl Partitioning {
+ /// Return the number of partitions, if known.
+ pub fn partition_count(&self) -> Option<usize> {
+ match self {
+ Self::RoundRobinBatch(partition_count) | Self::Hash(_, partition_count) => {
+ Some(*partition_count)
+ }
+ Self::Range(range) => Some(range.partition_count()),
+ Self::DistributeBy(_) => None,
+ }
+ }
+}
+
+/// Logical range partitioning.
+///
+/// [`RangePartitioning`] describes an ordered logical key space with split points.
+///
+/// - `ordering` defines the partitioning key and ordering using logical
+/// [`SortExpr`]s.
+/// - `split_points` define the boundaries between adjacent partitions.
+///
+/// Comparisons use the lexicographic order defined by `ordering`,
+/// including `ASC`/`DESC` and null ordering. Split points must be ordered
+/// according to that ordering, and each split point must have one value per
+/// ordering expression. See [`SplitPoint`] for the shared boundary contract.
+///
+/// The expressions are resolved against the declaring plan's schema. This
+/// constructor does not validate split point value types against the resolved
+/// expression types. Like other user-specified data properties such as
+/// sortedness, if a source declares range partitioning, it is responsible for
+/// placing each row in the partition described by the split points. DataFusion
+/// will not validate this is upheld.
+///
+/// NOTE: Planning [`LogicalPlan::Repartition`] with range partitioning is not
+/// currently supported. Range-aware optimizer and execution behavior will be
+/// introduced incrementally. See
+/// <https://github.com/apache/datafusion/issues/22395>.
+#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
+pub struct RangePartitioning {
+ /// Ordered logical partitioning key.
+ ordering: Vec<SortExpr>,
+ /// Boundaries between adjacent partitions.
+ split_points: Vec<SplitPoint>,
+}
+
+impl RangePartitioning {
+ /// Creates logical range partitioning metadata and validates split point
+ /// shape and ordering.
+ pub fn try_new(
+ ordering: Vec<SortExpr>,
+ split_points: Vec<SplitPoint>,
+ ) -> Result<Self> {
+ if ordering.is_empty() {
+ return plan_err!("Range partitioning requires non-empty ordering");
+ }
+
+ validate_range_split_points(&split_points, &logical_sort_options(&ordering))?;
+
+ Ok(Self {
+ ordering,
+ split_points,
+ })
+ }
+
+ /// Return the number of partitions.
+ pub fn partition_count(&self) -> usize {
+ self.split_points.len() + 1
+ }
+
+ /// Returns the ordering that defines the range key.
+ pub fn ordering(&self) -> &[SortExpr] {
+ &self.ordering
+ }
+
+ /// Returns the ordered split points between partitions.
+ pub fn split_points(&self) -> &[SplitPoint] {
+ &self.split_points
+ }
+}
+
+fn logical_sort_options(ordering: &[SortExpr]) -> Vec<SortOptions> {
+ ordering
+ .iter()
+ .map(|sort_expr| SortOptions {
+ descending: !sort_expr.asc,
+ nulls_first: sort_expr.nulls_first,
+ })
+ .collect()
+}
+
+impl Display for RangePartitioning {
+ fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+ let ordering = self
+ .ordering()
+ .iter()
+ .map(ToString::to_string)
+ .collect::<Vec<_>>()
+ .join(", ");
+ let split_points = self
Review Comment:
Using the `.join()` method from `itertools::Itertools` should allow you to avoid the Vec allocation:
```suggestion
.map(ToString::to_string)
.join(", ");
```
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1264,6 +1264,14 @@ impl DefaultPhysicalPlanner {
.collect::<Result<Vec<_>>>()?;
Partitioning::Hash(runtime_expr, *n)
}
+ LogicalPartitioning::Range(_) => {
+ // TODO: Support planning LogicalPlan::Repartition with
+ // range partitioning.
+ // Tracked by https://github.com/apache/datafusion/issues/22786
+ return not_impl_err!(
+ "Physical plan does not support Range repartitioning"
+ );
+ }
Review Comment:
Don't we have everything we need already for creating this mapping?
```rust
LogicalPartitioning::Range(v) => {
let sort_exprs = create_physical_sort_exprs(
v.ordering(),
input_dfschema,
execution_props,
)?;
Partitioning::Range(RangePartitioning::new(
LexOrdering::new(sort_exprs).unwrap(),
v.split_points().to_vec(),
))
```
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -3300,6 +3308,25 @@ mod tests {
aggregate_explain(&logical_plan).await
}
+ #[tokio::test]
+ async fn logical_range_repartition_is_not_supported() -> Result<()> {
Review Comment:
It would be cool if we could make this actually pass in this PR
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -4397,22 +4428,142 @@ impl Debug for Subquery {
}
}
-/// Logical partitioning schemes supported by [`LogicalPlan::Repartition`]
+/// Logical partitioning schemes.
///
-/// See [`Partitioning`] for more details on partitioning
+/// A scheme can describe either requested repartitioning in
+/// [`LogicalPlan::Repartition`] or a partitioning property declared by a source.
+/// Some schemes are only valid as metadata until planner support is added.
///
-/// [`Partitioning`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/enum.Partitioning.html#
+/// For physical execution partitioning, see
+/// [`datafusion_physical_expr::Partitioning`].
+///
+/// [`datafusion_physical_expr::Partitioning`]: https://docs.rs/datafusion/latest/datafusion/physical_expr/enum.Partitioning.html#
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
pub enum Partitioning {
/// Allocate batches using a round-robin algorithm and the specified number of partitions
RoundRobinBatch(usize),
/// Allocate rows based on a hash of one of more expressions and the specified number
/// of partitions.
Hash(Vec<Expr>, usize),
+ /// Partition rows by ranges.
+ /// See [`RangePartitioning`] for the logical contract.
+ Range(RangePartitioning),
/// The DISTRIBUTE BY clause is used to repartition the data based on the input expressions
DistributeBy(Vec<Expr>),
}
+impl Partitioning {
+ /// Return the number of partitions, if known.
+ pub fn partition_count(&self) -> Option<usize> {
+ match self {
+ Self::RoundRobinBatch(partition_count) | Self::Hash(_, partition_count) => {
+ Some(*partition_count)
+ }
+ Self::Range(range) => Some(range.partition_count()),
+ Self::DistributeBy(_) => None,
+ }
+ }
+}
+
+/// Logical range partitioning.
+///
+/// [`RangePartitioning`] describes an ordered logical key space with split points.
+///
+/// - `ordering` defines the partitioning key and ordering using logical
+/// [`SortExpr`]s.
+/// - `split_points` define the boundaries between adjacent partitions.
+///
+/// Comparisons use the lexicographic order defined by `ordering`,
+/// including `ASC`/`DESC` and null ordering. Split points must be ordered
+/// according to that ordering, and each split point must have one value per
+/// ordering expression. See [`SplitPoint`] for the shared boundary contract.
+///
+/// The expressions are resolved against the declaring plan's schema. This
+/// constructor does not validate split point value types against the resolved
+/// expression types. Like other user-specified data properties such as
+/// sortedness, if a source declares range partitioning, it is responsible for
+/// placing each row in the partition described by the split points. DataFusion
+/// will not validate this is upheld.
+///
+/// NOTE: Planning [`LogicalPlan::Repartition`] with range partitioning is not
+/// currently supported. Range-aware optimizer and execution behavior will be
+/// introduced incrementally. See
+/// <https://github.com/apache/datafusion/issues/22395>.
+#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
+pub struct RangePartitioning {
+ /// Ordered logical partitioning key.
+ ordering: Vec<SortExpr>,
+ /// Boundaries between adjacent partitions.
+ split_points: Vec<SplitPoint>,
+}
+
+impl RangePartitioning {
+ /// Creates logical range partitioning metadata and validates split point
+ /// shape and ordering.
+ pub fn try_new(
+ ordering: Vec<SortExpr>,
+ split_points: Vec<SplitPoint>,
+ ) -> Result<Self> {
+ if ordering.is_empty() {
+ return plan_err!("Range partitioning requires non-empty ordering");
+ }
+
+ validate_range_split_points(&split_points, &logical_sort_options(&ordering))?;
+
+ Ok(Self {
+ ordering,
+ split_points,
+ })
+ }
+
+ /// Return the number of partitions.
+ pub fn partition_count(&self) -> usize {
+ self.split_points.len() + 1
+ }
+
+ /// Returns the ordering that defines the range key.
+ pub fn ordering(&self) -> &[SortExpr] {
+ &self.ordering
+ }
+
+ /// Returns the ordered split points between partitions.
+ pub fn split_points(&self) -> &[SplitPoint] {
+ &self.split_points
+ }
+}
+
+fn logical_sort_options(ordering: &[SortExpr]) -> Vec<SortOptions> {
+ ordering
+ .iter()
+ .map(|sort_expr| SortOptions {
+ descending: !sort_expr.asc,
+ nulls_first: sort_expr.nulls_first,
+ })
+ .collect()
+}
+
+impl Display for RangePartitioning {
+ fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+ let ordering = self
+ .ordering()
+ .iter()
+ .map(ToString::to_string)
+ .collect::<Vec<_>>()
+ .join(", ");
+ let split_points = self
+ .split_points()
+ .iter()
+ .map(ToString::to_string)
+ .collect::<Vec<_>>()
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "gabotechs (via GitHub)" <gi...@apache.org>.
gabotechs merged PR #22777:
URL: https://github.com/apache/datafusion/pull/22777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "gene-bordegaray (via GitHub)" <gi...@apache.org>.
gene-bordegaray commented on code in PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#discussion_r3367389847
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1264,6 +1264,11 @@ impl DefaultPhysicalPlanner {
.collect::<Result<Vec<_>>>()?;
Partitioning::Hash(runtime_expr, *n)
}
+ LogicalPartitioning::Range(_) => {
+ return not_impl_err!(
+ "Physical plan does not support Range repartitioning"
+ );
Review Comment:
I created small issues for each not impl. They are not very great descriptions but for tracking for now
- #22786
- #22787
- #22788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "gene-bordegaray (via GitHub)" <gi...@apache.org>.
gene-bordegaray commented on code in PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#discussion_r3365198292
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1264,6 +1264,11 @@ impl DefaultPhysicalPlanner {
.collect::<Result<Vec<_>>>()?;
Partitioning::Hash(runtime_expr, *n)
}
+ LogicalPartitioning::Range(_) => {
+ return not_impl_err!(
+ "Physical plan does not support Range repartitioning"
+ );
Review Comment:
yes good catch I can add the epic: #22395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add logical range partitioning representation [datafusion]
Posted by "gabotechs (via GitHub)" <gi...@apache.org>.
gabotechs commented on PR #22777:
URL: https://github.com/apache/datafusion/pull/22777#issuecomment-4669062892
I know 👍 it's completely fine, you responded with code so that's good enough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org