You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/19 17:46:31 UTC
[GitHub] [flink-statefun] tillrohrmann opened a new pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.2
tillrohrmann opened a new pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283
This PR bumps the Flink dependency to 1.14.2.
Optional: This PR also contains a very simple migration test based on the `EmbeddedSmokeHarnessTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tillrohrmann commented on a change in pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#discussion_r788701776
##########
File path: statefun-e2e-tests/statefun-smoke-e2e-embedded/src/test/java/org/apache/flink/statefun/e2e/smoke/embedded/EmbeddedSmokeHarnessMigrationTest.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.statefun.e2e.smoke.embedded;
+
+import static org.apache.flink.statefun.e2e.smoke.SmokeRunner.awaitVerificationSuccess;
+
+import java.io.File;
+import java.net.URI;
+import java.util.Arrays;
+import java.util.Collection;
+import org.apache.commons.io.FileUtils;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.statefun.e2e.smoke.SimpleVerificationServer;
+import org.apache.flink.statefun.e2e.smoke.SmokeRunnerParameters;
+import org.apache.flink.statefun.flink.harness.Harness;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@RunWith(Parameterized.class)
+public class EmbeddedSmokeHarnessMigrationTest {
Review comment:
I think this sounds like a good idea. Having these test to ensure that nothing is breaking unintentionally is a good improvement. I will remove the commit that introduced the harness test and we continue based on the migration test JIRA ticket you'll create.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman commented on a change in pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#discussion_r788618532
##########
File path: statefun-flink/statefun-flink-harness/src/main/java/org/apache/flink/statefun/flink/harness/Harness.java
##########
@@ -126,6 +129,14 @@ public Harness withSavepointLocation(String savepointLocation) {
}
public void start() throws Exception {
+ try {
+ startAsync().getJobExecutionResult().get();
+ } catch (ExecutionException ee) {
+ ExceptionUtils.rethrowException(ExceptionUtils.stripExecutionException(ee));
+ }
+ }
+
+ public JobClient startAsync() throws Exception {
Review comment:
I'm not sure that I'd like to expose the `JobClient` as a public method on the `Harness`.
How about we think about it as a followup PR?
##########
File path: statefun-e2e-tests/statefun-smoke-e2e-embedded/src/test/java/org/apache/flink/statefun/e2e/smoke/embedded/EmbeddedSmokeHarnessMigrationTest.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.statefun.e2e.smoke.embedded;
+
+import static org.apache.flink.statefun.e2e.smoke.SmokeRunner.awaitVerificationSuccess;
+
+import java.io.File;
+import java.net.URI;
+import java.util.Arrays;
+import java.util.Collection;
+import org.apache.commons.io.FileUtils;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.statefun.e2e.smoke.SimpleVerificationServer;
+import org.apache.flink.statefun.e2e.smoke.SmokeRunnerParameters;
+import org.apache.flink.statefun.flink.harness.Harness;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@RunWith(Parameterized.class)
+public class EmbeddedSmokeHarnessMigrationTest {
Review comment:
Thanks for adding a migration test!
This test would catch any internal migration issues with the core statefun job graph.
Perhaps we need to followup with a separate e2e migration test, that runs within its own migration profile, that includes at least a Kafka ingress/egress pair.
It can be completely based remote functions, without any verification/failure injection aspects to it, and this probably should be based on `testcontainers` instead of the harness.
having test containers will allows the test to create a save point in an arbitrary previous version (say 3.1.1)
based on the previously released official docker images, and load it with the current version.
The test would be bit more time consuming, and that's why I would recommend that to run under a different profile.
If this is something you find reasonable, then I'll create a followup JIRA issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tillrohrmann commented on pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#issuecomment-1020149050
I will propose to create a new release today. So expect that the release happens later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] cosmir17 commented on pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
cosmir17 commented on pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#issuecomment-1020174746
Thank you for your kindness 🥳🥰 @tillrohrmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tillrohrmann closed pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tillrohrmann commented on pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#issuecomment-1020216353
@cosmir17 if you want to help with the release verification, then I can ping you once we have the release artifacts created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tillrohrmann commented on pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#issuecomment-1017434200
Thanks a lot for your review @igalshilman. I've removed the migration test commit and rebased onto the latest master. Will merge it once GHA gives green light.
I'd be +1 for following up with a dedicated JIRA ticket for adding a migration test. It will help spotting incompatible changes faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tillrohrmann commented on a change in pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#discussion_r788698736
##########
File path: statefun-flink/statefun-flink-harness/src/main/java/org/apache/flink/statefun/flink/harness/Harness.java
##########
@@ -126,6 +129,14 @@ public Harness withSavepointLocation(String savepointLocation) {
}
public void start() throws Exception {
+ try {
+ startAsync().getJobExecutionResult().get();
+ } catch (ExecutionException ee) {
+ ExceptionUtils.rethrowException(ExceptionUtils.stripExecutionException(ee));
+ }
+ }
+
+ public JobClient startAsync() throws Exception {
Review comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] cosmir17 commented on pull request #283: [FLINK-25708] Bump Flink dependency to 1.14.3
Posted by GitBox <gi...@apache.org>.
cosmir17 commented on pull request #283:
URL: https://github.com/apache/flink-statefun/pull/283#issuecomment-1019923449
The pr has been merged 🎉🥳 I should just wait. Any news on public dependency release? @tillrohrmann 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org