You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2015/08/12 01:41:49 UTC
Review Request 37376: Ambari agent should support configuration where
it does not attempt to download stack scripts from the server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37376/
-----------------------------------------------------------
Review request for Ambari, Jayush Luniya and Sid Wagle.
Bugs: AMBARI-12727
https://issues.apache.org/jira/browse/AMBARI-12727
Repository: ambari
Description
-------
On hosted scenarios, the service provider controls the image (VM or docker) in terms of what package is deployed or what customizations have been done to specific stacks. During image preparation they can modify the server as well as client folders and thus do need any form of auto-sync between agent and server instances.
This feature introduces a knob to disable auto synchronization of stack definitions between the server and the agent.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01a573c
ambari-agent/src/main/python/ambari_agent/Controller.py 801b85a
ambari-agent/src/main/python/ambari_agent/FileCache.py be5c23c
ambari-agent/src/test/python/ambari_agent/TestFileCache.py da08782
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 87cc7a4
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 15d7904
Diff: https://reviews.apache.org/r/37376/diff/
Testing
-------
Manually tested with the flag on/off. Ran unit tests on agents and server.
Thanks,
Sumit Mohanty
Re: Review Request 37376: Ambari agent should support configuration
where it does not attempt to download stack scripts from the server
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Aug. 12, 2015, 7:21 p.m., Jayush Luniya wrote:
> > Ship It!
Can you close this review?
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37376/#review95150
-----------------------------------------------------------
On Aug. 11, 2015, 11:41 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37376/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 11:41 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sid Wagle.
>
>
> Bugs: AMBARI-12727
> https://issues.apache.org/jira/browse/AMBARI-12727
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On hosted scenarios, the service provider controls the image (VM or docker) in terms of what package is deployed or what customizations have been done to specific stacks. During image preparation they can modify the server as well as client folders and thus do need any form of auto-sync between agent and server instances.
> This feature introduces a knob to disable auto synchronization of stack definitions between the server and the agent.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01a573c
> ambari-agent/src/main/python/ambari_agent/Controller.py 801b85a
> ambari-agent/src/main/python/ambari_agent/FileCache.py be5c23c
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py da08782
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 87cc7a4
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 15d7904
>
> Diff: https://reviews.apache.org/r/37376/diff/
>
>
> Testing
> -------
>
> Manually tested with the flag on/off. Ran unit tests on agents and server.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 37376: Ambari agent should support configuration
where it does not attempt to download stack scripts from the server
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37376/#review95150
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Aug. 11, 2015, 11:41 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37376/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 11:41 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sid Wagle.
>
>
> Bugs: AMBARI-12727
> https://issues.apache.org/jira/browse/AMBARI-12727
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On hosted scenarios, the service provider controls the image (VM or docker) in terms of what package is deployed or what customizations have been done to specific stacks. During image preparation they can modify the server as well as client folders and thus do need any form of auto-sync between agent and server instances.
> This feature introduces a knob to disable auto synchronization of stack definitions between the server and the agent.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01a573c
> ambari-agent/src/main/python/ambari_agent/Controller.py 801b85a
> ambari-agent/src/main/python/ambari_agent/FileCache.py be5c23c
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py da08782
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 87cc7a4
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 15d7904
>
> Diff: https://reviews.apache.org/r/37376/diff/
>
>
> Testing
> -------
>
> Manually tested with the flag on/off. Ran unit tests on agents and server.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 37376: Ambari agent should support configuration
where it does not attempt to download stack scripts from the server
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37376/#review95028
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Aug. 11, 2015, 11:41 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37376/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 11:41 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sid Wagle.
>
>
> Bugs: AMBARI-12727
> https://issues.apache.org/jira/browse/AMBARI-12727
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On hosted scenarios, the service provider controls the image (VM or docker) in terms of what package is deployed or what customizations have been done to specific stacks. During image preparation they can modify the server as well as client folders and thus do need any form of auto-sync between agent and server instances.
> This feature introduces a knob to disable auto synchronization of stack definitions between the server and the agent.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01a573c
> ambari-agent/src/main/python/ambari_agent/Controller.py 801b85a
> ambari-agent/src/main/python/ambari_agent/FileCache.py be5c23c
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py da08782
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 87cc7a4
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 15d7904
>
> Diff: https://reviews.apache.org/r/37376/diff/
>
>
> Testing
> -------
>
> Manually tested with the flag on/off. Ran unit tests on agents and server.
>
>
> Thanks,
>
> Sumit Mohanty
>
>