You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2025/02/15 21:33:32 UTC
(airflow) branch main updated: fix return job_id when async finish before deffed in BigQueryInsertJobOperator (#46753)
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 7ae64e9d241 fix return job_id when async finish before deffed in BigQueryInsertJobOperator (#46753)
7ae64e9d241 is described below
commit 7ae64e9d24177245347ec2662257525e68547668
Author: nakamura1878 <na...@sansan.com>
AuthorDate: Sun Feb 16 06:33:26 2025 +0900
fix return job_id when async finish before deffed in BigQueryInsertJobOperator (#46753)
---
.../google/src/airflow/providers/google/cloud/operators/bigquery.py | 1 +
.../tests/provider_tests/google/cloud/operators/test_bigquery.py | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py b/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
index d144141b0e6..952f52612e6 100644
--- a/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
+++ b/providers/google/src/airflow/providers/google/cloud/operators/bigquery.py
@@ -2865,6 +2865,7 @@ class BigQueryInsertJobOperator(GoogleCloudBaseOperator, _BigQueryInsertJobOpera
)
self.log.info("Current state of job %s is %s", job.job_id, job.state)
self._handle_job_error(job)
+ return self.job_id
def execute_complete(self, context: Context, event: dict[str, Any]) -> str | None:
"""
diff --git a/providers/google/tests/provider_tests/google/cloud/operators/test_bigquery.py b/providers/google/tests/provider_tests/google/cloud/operators/test_bigquery.py
index 1fc8ab93cdc..d95872b6c39 100644
--- a/providers/google/tests/provider_tests/google/cloud/operators/test_bigquery.py
+++ b/providers/google/tests/provider_tests/google/cloud/operators/test_bigquery.py
@@ -1488,9 +1488,11 @@ class TestBigQueryInsertJobOperator:
deferrable=True,
)
- op.execute(MagicMock())
+ result = op.execute(context=MagicMock())
+
assert not mock_defer.called
assert "Current state of job" in caplog.text
+ assert result == real_job_id
@mock.patch("airflow.providers.google.cloud.operators.bigquery.BigQueryInsertJobOperator.defer")
@mock.patch("airflow.providers.google.cloud.operators.bigquery.BigQueryHook")