You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "tgravescs (via GitHub)" <gi...@apache.org> on 2023/02/21 16:18:41 UTC

[GitHub] [spark] tgravescs commented on pull request #39127: [SPARK-41585][YARN] The Spark exclude node functionality for YARN should work independently of dynamic allocation

tgravescs commented on PR #39127:
URL: https://github.com/apache/spark/pull/39127#issuecomment-1438754580

   I was thinking just basic unit test were you set the config and then create the YarnAllocatorNodeHealthTracker and validate it initialized them properly and called the amclient with expected values. Add comment about covering non dynamic allocation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org