You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by uw...@apache.org on 2019/03/03 18:25:53 UTC

[arrow] branch master updated: ARROW-4737: run C# tests in CI

This is an automated email from the ASF dual-hosted git repository.

uwe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new c35a3e6  ARROW-4737: run C# tests in CI
c35a3e6 is described below

commit c35a3e6e6c5e87490489f4709997646f7c0ec7e8
Author: Eric Erhardt <er...@microsoft.com>
AuthorDate: Sun Mar 3 19:25:32 2019 +0100

    ARROW-4737: run C# tests in CI
    
    The C# tests aren't running in CI because they are being filtered out. Adding detection logic for C#, so the tests run when `csharp` code changes.
    
    @wesm @chutchinson @pgovind
    
    Author: Eric Erhardt <er...@microsoft.com>
    
    Closes #3788 from eerhardt/FixCSharpCI and squashes the following commits:
    
    7aaf8aa5 <Eric Erhardt> ARROW-4737: run C# tests in CI
---
 ci/appveyor-filter-changes.bat | 7 +++++++
 ci/detect-changes.py           | 6 ++++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/ci/appveyor-filter-changes.bat b/ci/appveyor-filter-changes.bat
index e78f91f..e506e11 100644
--- a/ci/appveyor-filter-changes.bat
+++ b/ci/appveyor-filter-changes.bat
@@ -29,6 +29,13 @@ if "%JOB%" == "Rust" (
         echo ===
         appveyor exit
     )
+) else if "%JOB%" == "C#" (
+    if "%ARROW_CI_CSHARP_AFFECTED%" == "0" (
+        echo ===
+        echo === No C# changes, exiting job
+        echo ===
+        appveyor exit
+    )
 ) else (
     if "%ARROW_CI_PYTHON_AFFECTED%" == "0" (
         echo ===
diff --git a/ci/detect-changes.py b/ci/detect-changes.py
index 8e24c3f..8c7ce17 100644
--- a/ci/detect-changes.py
+++ b/ci/detect-changes.py
@@ -108,7 +108,7 @@ def list_appveyor_affected_files():
 
 
 LANGUAGE_TOPICS = ['c_glib', 'cpp', 'docs', 'go', 'java', 'js', 'python',
-                   'r', 'ruby', 'rust']
+                   'r', 'ruby', 'rust', 'csharp']
 
 ALL_TOPICS = LANGUAGE_TOPICS + ['integration', 'site', 'dev']
 
@@ -124,7 +124,7 @@ AFFECTED_DEPENDENCIES = {
 }
 
 COMPONENTS = {'cpp', 'java', 'c_glib', 'r', 'ruby', 'integration', 'js',
-              'rust', 'site', 'go', 'docs', 'python', 'dev'}
+              'rust', 'csharp', 'site', 'go', 'docs', 'python', 'dev'}
 
 
 def get_affected_topics(affected_files):
@@ -241,6 +241,7 @@ def test_get_affected_topics():
         'r': True,
         'ruby': True,
         'rust': False,
+        'csharp': False,
         'integration': True,
         'site': False,
         'dev': False
@@ -258,6 +259,7 @@ def test_get_affected_topics():
         'r': True,
         'ruby': True,
         'rust': True,
+        'csharp': True,
         'integration': True,
         'site': False,
         'dev': False