You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/02 05:36:56 UTC

[GitHub] [solr] dsmiley commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1059840960


##########
solr/core/src/test-files/solr/solr.xml:
##########
@@ -35,11 +35,6 @@
     <int name="connTimeout">${connTimeout:15000}</int>
   </shardHandlerFactory>
 
-  <transientCoreCacheFactory name="transientCoreCacheFactory" class="TransientSolrCoreCacheFactoryDefault">

Review Comment:
   I don't think it's an either-or, I think of this as more evolutionary.  Feel free to propose CoreFactory separately.  You haven't outlined your whole idea but I presume SolrCores would *become* CoreFactory.  Progress.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org