You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2026/10/22 12:59:58 UTC

[PR] [CELEBORN-2500] Use ArrayDeque instead of LinkedList in TransportFrameDecoder [celeborn]

SteNicholas opened a new pull request, #3893:
URL: https://github.com/apache/celeborn/pull/3893

   ### What changes were proposed in this pull request?
   
   Replace the pending input buffer queue in `TransportFrameDecoder` with `ArrayDeque`. The queue retains its FIFO semantics, with no changes to frame decoding or buffer release behavior.
   
   ### Why are the changes needed?
   
   `LinkedList` allocates a node for every incoming `ByteBuf`. `ArrayDeque` reuses its backing array, avoiding these per-read node allocations on the Netty receive path.
   
   ### Does this PR resolve a correctness bug?
   
   - [ ] Yes
   
   ### Does this PR introduce _any_ user-facing change?
   
   - [ ] Yes
   
   ### How was this patch tested?
   
   - All 15 tests in `RpcIntegrationSuiteJ` and `SSLRpcIntegrationSuiteJ` passed on JDK 17.
   - `common` module Spotless checks and `git diff --check` passed.
   
   ```sh
   build/mvn -B -ntp -pl common -am test \
     -Dtest=RpcIntegrationSuiteJ,SSLRpcIntegrationSuiteJ \
     -DwildcardSuites=none
   build/mvn -B -ntp -pl common spotless:check
   git diff --check upstream/main...HEAD
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2500] Use ArrayDeque instead of LinkedList in TransportFrameDecoder [celeborn]

Posted by "zaynt4606 (via GitHub)" <gi...@apache.org>.
zaynt4606 closed pull request #3893: [CELEBORN-2500] Use ArrayDeque instead of LinkedList in TransportFrameDecoder
URL: https://github.com/apache/celeborn/pull/3893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2500] Use ArrayDeque instead of LinkedList in TransportFrameDecoder [celeborn]

Posted by "zaynt4606 (via GitHub)" <gi...@apache.org>.
zaynt4606 commented on PR #3893:
URL: https://github.com/apache/celeborn/pull/3893#issuecomment-6355880801

   **Merge Summary:**
   - merged into main https://github.com/apache/celeborn/commit/924b054f
   - merged into branch-0.7 https://github.com/apache/celeborn/commit/b44e509f
   
   *Posted by `merge_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2500] Use ArrayDeque instead of LinkedList in TransportFrameDecoder [celeborn]

Posted by "zaynt4606 (via GitHub)" <gi...@apache.org>.
zaynt4606 commented on PR #3893:
URL: https://github.com/apache/celeborn/pull/3893#issuecomment-6355894467

   Thanks @SteNicholas for the contribution!
   Merged to main(v1.0.0), branch-0.7(v0.7.1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org