You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/04/27 03:23:52 UTC

[kudu-CR] Retry pre-move ksck check in case of transient errors

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10226


Change subject: Retry pre-move ksck check in case of transient errors
......................................................................

Retry pre-move ksck check in case of transient errors

ksck sometimes fails due to transient and harmless cluster conditions
like leader elections. This allows the pre-flight ksck check in the move
tool to retry on failure up to a short timeout in case the tablet
subject to the move is experiencing a transient error.

Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/10226/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
Gerrit-Change-Number: 10226
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] Retry pre-move ksck check in case of transient errors

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10226 )

Change subject: Retry pre-move ksck check in case of transient errors
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
Gerrit-Change-Number: 10226
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 27 Apr 2018 03:26:25 +0000
Gerrit-HasComments: No

[kudu-CR] Retry pre-move ksck check in case of transient errors

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10226 )

Change subject: Retry pre-move ksck check in case of transient errors
......................................................................

Retry pre-move ksck check in case of transient errors

ksck sometimes fails due to transient and harmless cluster conditions
like leader elections. This allows the pre-flight ksck check in the move
tool to retry on failure up to a short timeout in case the tablet
subject to the move is experiencing a transient error.

Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
Reviewed-on: http://gerrit.cloudera.org:8080/10226
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Will Berkeley: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
Gerrit-Change-Number: 10226
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Retry pre-move ksck check in case of transient errors

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10226 )

Change subject: Retry pre-move ksck check in case of transient errors
......................................................................


Patch Set 1:

Unrelated flake.


-- 
To view, visit http://gerrit.cloudera.org:8080/10226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
Gerrit-Change-Number: 10226
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 27 Apr 2018 04:12:32 +0000
Gerrit-HasComments: No

[kudu-CR] Retry pre-move ksck check in case of transient errors

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed a vote on this change.

Change subject: Retry pre-move ksck check in case of transient errors
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/10226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
Gerrit-Change-Number: 10226
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Retry pre-move ksck check in case of transient errors

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10226 )

Change subject: Retry pre-move ksck check in case of transient errors
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07371c0509725dd6a4d379b91a329561a86a988
Gerrit-Change-Number: 10226
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 27 Apr 2018 04:12:27 +0000
Gerrit-HasComments: No