You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/19 01:25:27 UTC
[GitHub] [druid] ccaominh opened a new pull request #9376: Make java version
check work on all shells
ccaominh opened a new pull request #9376: Make java version check work on all shells
URL: https://github.com/apache/druid/pull/9376
### Description
Previously, `perl verify-java` would fail on shells like zsh, which would cause the quickstart scripts (e.g., bin/start-micro-quickstart) to fail unless the DRUID_SKIP_JAVA_SKIP environment variable is set.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] manually tested with sh, bash, csh, tcsh, ksh, zsh.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh merged pull request #9376: Make java version check
work on all shells
Posted by GitBox <gi...@apache.org>.
ccaominh merged pull request #9376: Make java version check work on all shells
URL: https://github.com/apache/druid/pull/9376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on issue #9376: Make java version check
work on all shells
Posted by GitBox <gi...@apache.org>.
ccaominh commented on issue #9376: Make java version check work on all shells
URL: https://github.com/apache/druid/pull/9376#issuecomment-588055157
> Is this for fixing `sh - invalid option` when running quickstart script?
Yes. I observed that `echo -n foo` would print "-n foo" on some shells instead of printing "foo" without a newline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm3 commented on issue #9376: Make java version check
work on all shells
Posted by GitBox <gi...@apache.org>.
maytasm3 commented on issue #9376: Make java version check work on all shells
URL: https://github.com/apache/druid/pull/9376#issuecomment-588024331
Is this for fixing `sh - invalid option` when running quickstart script?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org