[GitHub] andrewfayres commented on a change in pull request #13678: [MXNET-1260] Float64 DType computation support in Scala/Java

[GitBox <gi...@apache.org>]

andrewfayres commented on a change in pull request #13678: [MXNET-1260] Float64 DType computation support in Scala/Java
URL: https://github.com/apache/incubator-mxnet/pull/13678#discussion_r246884359
 
 

 ##########
 File path: scala-package/core/src/test/scala/org/apache/mxnet/IOSuite.scala
 ##########
 @@ -303,5 +303,32 @@ class IOSuite extends FunSuite with BeforeAndAfterAll {
     assert(dataDesc(0).layout == Layout.NTC)
     assert(labelDesc(0).dtype == DType.Int32)
     assert(labelDesc(0).layout == Layout.NT)
+
+
+    // Test with passing Float64 hardcoded as Dtype of data
+    val dataIter4 = new NDArrayIter(
+      IO.initDataDesc(data, false, "data", DType.Float64, Layout.NTC),
+      IO.initDataDesc(label, false, "label", DType.Int32, Layout.NT),
 
 Review comment:
   Any reason for the label to not also have DType.Float64? I know people don't really use that for labels but we added the capability so should test it as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services