You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by bennetelli <gi...@git.apache.org> on 2017/04/27 13:38:22 UTC
[GitHub] activemq-artemis pull request #1231: ARTEMIS-904 Remove cyclic dependencies ...
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/1231
ARTEMIS-904 Remove cyclic dependencies from artemis-cli
move classes and methods to their correct location to avoid cyclic dependencies between packages and classes. I also removed unused methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1231
----
commit 1993e14c224eabae63b8432c0cbce5f6b78cb2d1
Author: Bennet Schulz <ma...@bennet-schulz.de>
Date: 2017-04-27T13:36:38Z
ARTEMIS-904 Remove cyclic dependencies from artemis-cli
move classes and methods to their correct location to avoid cyclic dependencies between packages and classes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1231: ARTEMIS-904 Remove cyclic dependencies from ar...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1231: ARTEMIS-904 Remove cyclic dependencies from ar...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
I rebased this and merged it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1231: ARTEMIS-904 Remove cyclic dependencies from ar...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
Please squash the commits. Also, keep an eye on formatting. It looks like a few things got changed in the last commit that seem incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1231: ARTEMIS-904 Remove cyclic dependencies from ar...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
@jbertram / @bennetelli nothing works after this.. you can't even start a server.
What was changed here that broker it? I may have to revert it if not fixed by tomorrow. i have a release to make.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1231: ARTEMIS-904 Remove cyclic dependencies from ar...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
Looks like you may need to rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1231: ARTEMIS-904 Remove cyclic dependencies ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1231: ARTEMIS-904 Remove cyclic dependencies from ar...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
I don't understand. What specifically isn't working now? I ran the PR build myself which starts the broker quite a few times for different tests and everything worked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1231: ARTEMIS-904 Remove cyclic dependencies ...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1231#discussion_r113715125
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/util/ServerUtil.java ---
@@ -121,18 +121,6 @@ public static int getServer(Connection connection) {
return Integer.valueOf(port) - 61616;
}
- public static Connection getServerConnection(int server, Connection... connections) {
- for (Connection connection : connections) {
- ClientSession session = ((ActiveMQConnection) connection).getInitialSession();
- TransportConfiguration transportConfiguration = session.getSessionFactory().getConnectorConfiguration();
- String port = (String) transportConfiguration.getParams().get("port");
- if (Integer.valueOf(port) == server + 61616) {
- return connection;
- }
- }
- return null;
- }
-
--- End diff --
This method is used in the "clustered-static-oneway" example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1231: ARTEMIS-904 Remove cyclic dependencies from ar...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
Try running a server... it won't work...
one way to check is to run ./artemis-distribution/src/test/scripts/validate-spaces.sh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---