[GitHub] [dubbo-go-hessian2] wongoo edited a comment on pull request #243: Ftr/support register with no pojo object

[GitBox <gi...@apache.org>]

wongoo edited a comment on pull request #243:
URL: https://github.com/apache/dubbo-go-hessian2/pull/243#issuecomment-727981961


   @LaurenceLiZhixin  thanks for submit this pr.
   
   1. it's not efficient to check whether it's exist a field named JavaClassName, u should call checkPOJORegistry first to check whether it's being registered or not.  
   2. SHOULD NOT copy a whole method and just change a little logic in it,  a better way is to create a new func `encNamedPOJOObject(javaClassName string, v interface{})` , and the original func `encPOJOObject` calling the new func.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org