[GitHub] [cassandra] maedhroz commented on a diff in pull request #1648: CASSANDRA-17663 Ensure FileStreamTask cannot compromise shared channel proxy for system table when interrupted

[GitBox <gi...@apache.org>]

maedhroz commented on code in PR #1648:
URL: https://github.com/apache/cassandra/pull/1648#discussion_r882979798


##########
src/java/org/apache/cassandra/streaming/StreamingChannel.java:
##########
@@ -49,6 +49,14 @@ public static void unsafeSet(StreamingChannel.Factory factory)
         }
 
         StreamingChannel create(InetSocketAddress to, int messagingVersion, Kind kind) throws IOException;
+
+        default StreamingChannel create(InetSocketAddress to,
+                                        InetSocketAddress preferred,
+                                        int messagingVersion,
+                                        StreamingChannel.Kind kind) throws IOException
+        {
+            throw new UnsupportedOperationException();

Review Comment:
   `BulkLoadConnectionFactory extends NettyStreamingConnectionFactory` right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org