You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/04/26 17:56:23 UTC
[GitHub] [superset] codecov[bot] commented on pull request #23831: fix: Preserve filters from previous drillings in drill by
codecov[bot] commented on PR #23831:
URL: https://github.com/apache/superset/pull/23831#issuecomment-1523830584
## [Codecov](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23831](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e2b427) into [master](https://codecov.io/gh/apache/superset/commit/40ae074ff08582363002a0cef662bea7cb063952?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40ae074) will **increase** coverage by `0.00%`.
> The diff coverage is `88.23%`.
> :exclamation: Current head 3e2b427 differs from pull request most recent head 35df33a. Consider uploading reports for the commit 35df33a to get more accurate results
```diff
@@ Coverage Diff @@
## master #23831 +/- ##
=======================================
Coverage 67.99% 68.00%
=======================================
Files 1937 1937
Lines 74934 74942 +8
Branches 8138 8138
=======================================
+ Hits 50954 50965 +11
+ Misses 21895 21892 -3
Partials 2085 2085
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.29% <87.50%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/SqlLab/components/SaveDatasetModal/index.tsx](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwvaW5kZXgudHN4) | `50.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.33% <50.00%> (-0.17%)` | :arrow_down: |
| [...tend/src/components/Chart/DrillBy/DrillByModal.tsx](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxCeS9EcmlsbEJ5TW9kYWwudHN4) | `74.07% <100.00%> (+1.52%)` | :arrow_up: |
| [...frontend/src/explore/actions/datasourcesActions.ts](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9kYXRhc291cmNlc0FjdGlvbnMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/23831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <100.00%> (-0.21%)` | :arrow_down: |
... and [8 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23831/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org